Skip to content

Fix debug symbol generation happening on every build#1117

Merged
jviotti merged 1 commit into
mainfrom
debug-symbols
Jul 10, 2026
Merged

Fix debug symbol generation happening on every build#1117
jviotti merged 1 commit into
mainfrom
debug-symbols

Conversation

@jviotti

@jviotti jviotti commented Jul 10, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode

augmentcode Bot commented Jul 10, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Prevents the UNIX debug-symbol extraction rule from re-running on every incremental build.

Changes:

  • After atomically replacing the stripped binary, touches the declared .debug output so its timestamp remains newer than the replaced binary.
  • Adds inline documentation explaining the ETXTBSY avoidance and why the final touch is needed.

🤖 Was this summary useful? React with 👍 or 👎

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: 9a2bc6e Previous: 608acda Ratio
Add one schema (0 existing) 323 ms 306 ms 1.06
Add one schema (100 existing) 30 ms 23 ms 1.30
Add one schema (1000 existing) 88 ms 70 ms 1.26
Add one schema (10000 existing) 754 ms 600 ms 1.26
Update one schema (1 existing) 21 ms 16 ms 1.31
Update one schema (101 existing) 29 ms 23 ms 1.26
Update one schema (1001 existing) 91 ms 70 ms 1.30
Update one schema (10001 existing) 755 ms 599 ms 1.26
Cached rebuild (1 existing) 7 ms 5 ms 1.40
Cached rebuild (101 existing) 9 ms 6 ms 1.50
Cached rebuild (1001 existing) 30 ms 19 ms 1.58
Cached rebuild (10001 existing) 258 ms 162 ms 1.59
Index 100 schemas 585 ms 369 ms 1.59
Index 1000 schemas 1479 ms 1244 ms 1.19
Index 10000 schemas 14136 ms 11320 ms 1.25
Index 10000 schemas (custom meta-schema) 17045 ms 13541 ms 1.26
Index 10000 schemas ($ref fan-out) 16724 ms 13942 ms 1.20

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: 9a2bc6e Previous: 608acda Ratio
Add one schema (0 existing) 437 ms 395 ms 1.11
Add one schema (100 existing) 115 ms 106 ms 1.08
Add one schema (1000 existing) 171 ms 160 ms 1.07
Add one schema (10000 existing) 822 ms 792 ms 1.04
Update one schema (1 existing) 104 ms 97 ms 1.07
Update one schema (101 existing) 111 ms 104 ms 1.07
Update one schema (1001 existing) 171 ms 161 ms 1.06
Update one schema (10001 existing) 826 ms 796 ms 1.04
Cached rebuild (1 existing) 9 ms 8 ms 1.13
Cached rebuild (101 existing) 11 ms 11 ms 1
Cached rebuild (1001 existing) 34 ms 31 ms 1.10
Cached rebuild (10001 existing) 284 ms 259 ms 1.10
Index 100 schemas 527 ms 498 ms 1.06
Index 1000 schemas 1645 ms 1630 ms 1.01
Index 10000 schemas 13684 ms 14430 ms 0.95
Index 10000 schemas (custom meta-schema) 16586 ms 17585 ms 0.94
Index 10000 schemas ($ref fan-out) 16404 ms 17055 ms 0.96

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 7c5778c into main Jul 10, 2026
5 checks passed
@jviotti jviotti deleted the debug-symbols branch July 10, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant