reimplement OpenSHC::Map::Rocks 100% - #196
Open
gynt wants to merge 2 commits into
Open
Conversation
TheRedDaemon
requested changes
Aug 22, 2026
TheRedDaemon
left a comment
TheRedDaemon
left a comment
Contributor
There was a problem hiding this comment.
Two small questions, although, not much about the content:
- Do we have an GM enum or something like that, that fits these ids? If not, no problem, no need to create it now.
- It is ok here, but can you really remove the space in the signature from the exporter:
void __cdecl Rocks ::UpdateRockFunc6()🙃?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Easiest functions ever. Makes you wonder why they had rock types and update functions at all... Perhaps they had some kind of template for entities, units, buildings that also have these update functions.