refactor: name unnamed functions with a best guess#142
Conversation
|
What do you expect from the review? |
|
I wasn't that sure. It felt too big to just push to main without a PR :) It has consequences for the work that has been done to SoundSystem because of renames. Should a rename of the cpp files be included in this PR? Should I hold back the one that is currently open in the PR? |
|
I think if they are already part of main and you rename something, you definitly need to pull the cpp files with you (rename the file and the function inside). |
This is a big one. I renamed all unnamed functions and clarified some others. So I would like to have a review from others. Are these function names clear?