Skip to content

refactor: name unnamed functions with a best guess#142

Open
gynt wants to merge 1 commit into
mainfrom
refactor/function-names
Open

refactor: name unnamed functions with a best guess#142
gynt wants to merge 1 commit into
mainfrom
refactor/function-names

Conversation

@gynt

@gynt gynt commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

This is a big one. I renamed all unnamed functions and clarified some others. So I would like to have a review from others. Are these function names clear?

@gynt gynt requested a review from TheRedDaemon July 3, 2026 08:12
@TheRedDaemon

Copy link
Copy Markdown
Contributor

What do you expect from the review?
Should I check Ghidra and try to confirm your reasoning? Or is is just about if the names are nice?

@gynt

gynt commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

I wasn't that sure. It felt too big to just push to main without a PR :)

It has consequences for the work that has been done to SoundSystem because of renames. Should a rename of the cpp files be included in this PR? Should I hold back the one that is currently open in the PR?

@TheRedDaemon

Copy link
Copy Markdown
Contributor

I think if they are already part of main and you rename something, you definitly need to pull the cpp files with you (rename the file and the function inside).
Functions that you know are being worked on however is not something you need to take into consideration outside of a comment on the PR for now.
That being said, these things might slip through should we ever become more, since we have no build validation yet. So it is something to keep in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants