feat(skills/developing-a-feature): distill the spec into the repo's decision-record format at teardown#28
Merged
Conversation
…ecision-record format at teardown
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the developing-a-feature skill’s Step 7 teardown guidance so “the spec stays” is no longer unconditional, ensuring long-lived architectural decisions end up in the repo’s actual decision-record system when one exists.
Changes:
- Makes spec retention conditional: if the repo has an established decision-record convention (e.g.,
docs/adrs/or equivalent), distill decisions into that format and delete the spec during teardown; otherwise keep the spec as the durable record. - Adds explicit instructions to follow house ADR format / any ADR-authoring skill and to gate distilled records on user review.
- Adds a matching red-flag entry clarifying that “the spec stays” applies only when no decision-record convention exists.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Step 7's teardown doctrine said "The spec stays — it's the durable ADR" unconditionally. In repos that maintain their own decision-record convention (an established
docs/adrs/with a house format), that leaves the feature's lasting decisions buried in a feature-scoped design doc at a scratch path outside the record engineers actually read — durable in letter, not in function. In a live session the user explicitly ordered the spec artifacts removed from the final PR and replaced with two house-format ADRs; a baseline agent following the skill's literal text kept the spec and only bridged the gap by consciously overriding the skill with its own judgment.Change
skills/developing-a-feature/SKILL.mdStep 7: the spec's fate becomes conditional on an observable predicate. Repo has a decision-record convention → distill the spec's lasting decisions into that format (house format, repo's authoring skill if one exists, user review of the drafts), land the records with the teardown, and delete the spec alongside the plan and state file. Repo has none → the spec stays, as before. One matching red-flag row.Verification (writing-skills RED → GREEN)
docs/adrs/a year out.