Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Removing featureflag for expanded audit logs#64415

Open
mohammadualam wants to merge 21 commits into
mainfrom
mohammadualam/enable-default-auditlogFF
Open

Removing featureflag for expanded audit logs#64415
mohammadualam wants to merge 21 commits into
mainfrom
mohammadualam/enable-default-auditlogFF

Conversation

@mohammadualam

Copy link
Copy Markdown

This PR removes featureflag which allows for sensitive actions to be logged without needing to enable the feature using the featureflag that was in place.

Test plan

CI checks and new tests

Changelog

  • More auditlogs for sensitive admin actions will be automatically logged.

@mohammadualam mohammadualam self-assigned this Aug 12, 2024
@cla-bot cla-bot Bot added the cla-signed label Aug 12, 2024
@github-actions

Copy link
Copy Markdown
Contributor

Caution

License checking failed, please read: how to deal with third parties licensing.

@github-actions

Copy link
Copy Markdown
Contributor

Caution

License checking failed, please read: how to deal with third parties licensing.

@github-actions

Copy link
Copy Markdown
Contributor

Caution

License checking failed, please read: how to deal with third parties licensing.

@github-actions

Copy link
Copy Markdown
Contributor

Caution

License checking failed, please read: how to deal with third parties licensing.

@mohammadualam mohammadualam requested a review from a team August 12, 2024 19:59

@shivasurya shivasurya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Comment thread cmd/frontend/graphqlbackend/site_test.go
@evict evict requested a review from a team August 13, 2024 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants