Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion packages/web/src/features/chat/utils.test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { expect, test, vi } from 'vitest'
import { fileReferenceToString, getAnswerPartFromAssistantMessage, groupMessageIntoSteps, repairReferences } from './utils'
import { fileReferenceToString, getAnswerPartFromAssistantMessage, groupMessageIntoSteps, isSameLanguageModelIdentity, repairReferences } from './utils'
import { FILE_REFERENCE_REGEX, ANSWER_TAG } from './constants';
import { SBChatMessage, SBChatMessagePart } from './types';

Expand Down Expand Up @@ -44,6 +44,31 @@ test('fileReferenceToString matches FILE_REFERENCE_REGEX', () => {
}))).toBe(true);
});

test('isSameLanguageModelIdentity ignores displayName', () => {
expect(isSameLanguageModelIdentity(
{
provider: 'anthropic',
model: 'claude-opus-4-7',
displayName: 'Claude Opus 4.7 (slow, highest quality)',
},
{
provider: 'anthropic',
model: 'claude-opus-4-7',
},
)).toBe(true);

expect(isSameLanguageModelIdentity(
{
provider: 'anthropic',
model: 'claude-opus-4-7',
},
{
provider: 'anthropic',
model: 'claude-sonnet-4-6',
},
)).toBe(false);
});

test('groupMessageIntoSteps returns an empty array when there are no parts', () => {
const parts: SBChatMessagePart[] = []

Expand Down
11 changes: 11 additions & 0 deletions packages/web/src/features/chat/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,17 @@ export const getLanguageModelKey = (model: LanguageModelInfo) => {
return `${model.provider}-${model.model}-${model.displayName}`;
}

/**
* Checks whether two language model infos refer to the same configured model.
*
* Unlike getLanguageModelKey, this intentionally ignores displayName because
* MCP clients can select models using only the externally visible provider and
* model fields.
*/
export const isSameLanguageModelIdentity = (a: LanguageModelInfo, b: LanguageModelInfo) => {
return a.provider === b.provider && a.model === b.model;
}

/**
* Given a file reference and a list of file sources, attempts to resolve the file source that the reference points to.
*/
Expand Down
4 changes: 2 additions & 2 deletions packages/web/src/features/mcp/askCodebase.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { sew } from "@/middleware/sew";
import { getConfiguredLanguageModels, getAISDKLanguageModelAndOptions, generateChatNameFromMessage, updateChatMessages } from "@/features/chat/utils.server";
import { LanguageModelInfo, SBChatMessage, SearchScope } from "@/features/chat/types";
import { convertLLMOutputToPortableMarkdown, getAnswerPartFromAssistantMessage, getLanguageModelKey } from "@/features/chat/utils";
import { convertLLMOutputToPortableMarkdown, getAnswerPartFromAssistantMessage, isSameLanguageModelIdentity } from "@/features/chat/utils";
import { ErrorCode } from "@/lib/errorCodes";
import { ServiceError, ServiceErrorException } from "@/lib/serviceError";
import { withOptionalAuth } from "@/middleware/withAuth";
Expand Down Expand Up @@ -58,7 +58,7 @@ export const askCodebase = (params: AskCodebaseParams): Promise<AskCodebaseResul
let languageModelConfig = configuredModels[0];
if (requestedLanguageModel) {
const matchingModel = configuredModels.find(
(m) => getLanguageModelKey(m) === getLanguageModelKey(requestedLanguageModel)
(m) => isSameLanguageModelIdentity(m, requestedLanguageModel)
);
if (!matchingModel) {
return {
Expand Down