Add Arista Goldfinch DTS for aspeed ast2700#561
Add Arista Goldfinch DTS for aspeed ast2700#561prajjwal-arista wants to merge 1 commit intosonic-net:masterfrom
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
paulmenzel
left a comment
paulmenzel
left a comment
There was a problem hiding this comment.
Thank you for your contribution.
It’d be great if you could extend the merge/pull request message, how you tested your patch.
There was a problem hiding this comment.
Please send it upstream to the Linux kernel for review.
There was a problem hiding this comment.
Thanks for the review.
This device tree is specific to the Arista Goldfinch platform and is intended for SONiC's linux-kernel repo.
We don't plan to upstream this to the mainline Linux kernel.
We can proceed with the review and merge here in sonic-linux-kernel itself.
There was a problem hiding this comment.
Thank you for your answer. But you seem to have a big misunderstanding about SONiC’s Linux kernel. It is based on the vanilla Linux kernel, to be more precise the one from Debian, and the goal is to have as few patches as possible. For all patches there needs to be a strategy how to get them upstream to reduce maintenance burden and to also ensure the quality as the upstream maintainers review patches. It’s not fire and forgot as seen in so many commercial operating systems in the firmware world. It’s forward ported every few years, and the probability is quite high that devices are going to be supported by the new Linux kernel.
So, please sent the patch upstream for review.
|
Depends on: #557 |
prajjwal-arista
force-pushed
the
aspeed-arista-goldfinch-dts
branch
from
6aadada to
8de297f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Thank you for your answer. But you seem to have a big misunderstanding about SONiC’s Linux kernel. It is based on the vanilla Linux kernel, to be more precise the one from Debian, and the goal is to have as few patches as possible. For all patches there needs to be a strategy how to get them upstream to reduce maintenance burden and to also ensure the quality as the upstream maintainers review patches. It’s not fire and forgot as seen in so many commercial operating systems in the firmware world. It’s forward ported every few years, and the probability is quite high that devices are going to be supported by the new Linux kernel.
So, please sent the patch upstream for review.
|
@prajjwal-arista can you fill in the PR comments using the template of this repo? (#561 (review)) Also please resolve the merge conflict. |
prajjwal-arista
force-pushed
the
aspeed-arista-goldfinch-dts
branch
from
8de297f to
c45ea3a
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@yxieca |
prajjwal-arista
force-pushed
the
aspeed-arista-goldfinch-dts
branch
from
c45ea3a to
53f5fe0
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prajjwal-arista
force-pushed
the
aspeed-arista-goldfinch-dts
branch
from
53f5fe0 to
654afe1
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prajjwal-arista
force-pushed
the
aspeed-arista-goldfinch-dts
branch
from
654afe1 to
c5412eb
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@yxieca we are good to merge this and the dependent: sonic-net/sonic-buildimage#26835 |
|
Please use imperative mood Add in the commit message title/summary, and the merge/pull request title. |
Add Arista Goldfinch DTS for aspeed ast2700. Tested this dts by building and booting up on aspeed ast2700 eval board. Signed-off-by: Prajjwal Singh <prajjwal@arista.com>
prajjwal-arista
force-pushed
the
aspeed-arista-goldfinch-dts
branch
from
c5412eb to
246e836
Compare
prajjwal-arista
changed the title
|
@paulmenzel |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
5 participants
Description
Add Arista Goldfinch DTS for aspeed ast2700 and adding CONFIG_PHY_ASPEED_SGMII=y in config.sonic-aspeed
Why I did it
Add device tree source to support Arista Goldfinch platform having aspeed ast2700
Patch List
How I did it
Added dts to sonic-potches and built.
How i tested it
Built and booted up with the dts changes on bmc dut.