Eager load line item details on the admin order page to avoid N+1s#6500
Merged
jarednorman merged 1 commit intoJul 16, 2026
Merged
Conversation
houndci-bot
reviewed
Jun 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6500 +/- ##
=======================================
Coverage 92.02% 92.02%
=======================================
Files 1035 1035
Lines 21125 21125
=======================================
Hits 19440 19440
Misses 1685 1685 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The admin order page rendered each line item's variant, product, images and option values lazily, so the query count grew with the number of items in the order. Eager loading those associations keeps the page's query count constant regardless of how many line items the order has.
798c60d to
cdff698
Compare
mamhoff
approved these changes
Jul 16, 2026
jarednorman
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The admin order page loaded each line item's variant, product, images and option values lazily while rendering the cart, so the page's query count grew with the number of line items on the order.