Repository navigation
Conversation
- Add `pnpm test:ecosystem`. It checks the built plugin against the Vite version installed in the repository: dev client and SSR transforms, HMR runtime injection, a client build, an SSR build, a dependency with a `solid` export condition, and no deprecation warnings. - It needs no browser, no network and no example installs, so vite-ecosystem-ci can run it after it replaces Vite. - `scripts/test-examples.ts` exited with code 0 when an example failed, because `cleanup()` called `process.exit(0)` before `process.exit(1)`. It now exits with code 1. Refs #285 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #285 on
main(1.x). The same script fornextis in a separate PR.Adds a
test:ecosystemscript that vite-ecosystem-ci can run against a Vite build.Changes
pnpm test:ecosystemrunsscripts/test-ecosystem.mjsagainst the installed Vite. It checks:solidexport condition;scripts/test-examples.tsnow exits with code 1 when an example fails. Before, its cleanup calledprocess.exit(0), so a failed run still exited 0.nextalready has this fix.What vite-ecosystem-ci needs
These changes go in vitejs/vite-ecosystem-ci and are not part of this PR.
tests/vite-plugin-solid.tsfile that callsrunInRepowithrepo: 'solidjs/solid-vite-plugin',build: 'build'andtest: 'test:ecosystem'.pnpm workflow:generatethere.nextrequires Vite 8 or 9.mainsupports Vite 3 to 9.Testing
pnpm test:ecosystempasses with Vite 6.0.9 and Vite 8.0.0.🤖 Generated with Claude Code