Skip to content

ci: add a test:ecosystem script for vite-ecosystem-ci - #452

Open
lxsmnsyc wants to merge 1 commit into
mainfrom
ci/285-ecosystem-test-main
Open

lxsmnsyc wants to merge 1 commit into
mainfrom
ci/285-ecosystem-test-main

Conversation

@lxsmnsyc

Copy link
Copy Markdown
Member

Part of #285 on main (1.x). The same script for next is in a separate PR.

Adds a test:ecosystem script that vite-ecosystem-ci can run against a Vite build.

Changes

  • pnpm test:ecosystem runs scripts/test-ecosystem.mjs against the installed Vite. It checks:
    • dev client and SSR transforms;
    • HMR code injection;
    • client and SSR builds;
    • a dependency with a solid export condition;
    • that no deprecation warnings are printed.
  • It needs no browser, no network and no example installs.
  • scripts/test-examples.ts now exits with code 1 when an example fails. Before, its cleanup called process.exit(0), so a failed run still exited 0. next already has this fix.

What vite-ecosystem-ci needs

These changes go in vitejs/vite-ecosystem-ci and are not part of this PR.

  • A tests/vite-plugin-solid.ts file that calls runInRepo with repo: 'solidjs/solid-vite-plugin', build: 'build' and test: 'test:ecosystem'.
  • Running pnpm workflow:generate there.
  • A choice of branch to track. next requires Vite 8 or 9. main supports Vite 3 to 9.

Testing

  • pnpm test:ecosystem passes with Vite 6.0.9 and Vite 8.0.0.
  • Not tested under vite-ecosystem-ci's own override flow.

🤖 Generated with Claude Code

- Add `pnpm test:ecosystem`. It checks the built plugin against the Vite
  version installed in the repository: dev client and SSR transforms, HMR
  runtime injection, a client build, an SSR build, a dependency with a
  `solid` export condition, and no deprecation warnings.
- It needs no browser, no network and no example installs, so
  vite-ecosystem-ci can run it after it replaces Vite.
- `scripts/test-examples.ts` exited with code 0 when an example failed,
  because `cleanup()` called `process.exit(0)` before `process.exit(1)`.
  It now exits with code 1.

Refs #285

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Oct 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 5e07f54

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Oct 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/vite-plugin-solid@452

commit: 5e07f54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant