Record client-reachable server function ids in the persisted manifest - #345
Merged
Conversation
dist/client/.vite/solid-server-functions.json grows from a module list to
{ modules, functions: [{ id, name, module }] }: every server function the
client compile emitted a reference to, by wire id. Build tooling that needs
the client-reachable set — a static-site prerenderer verifying each
reachable function was captured — reads it here instead of re-deriving it
from compiled output. The legacy array shape is still accepted on read;
the type is exported as PersistedServerFunctionManifest.
Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: 9fbbef6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The persisted manifest at
dist/client/.vite/solid-server-functions.jsongrows from a module list to{ modules: string[], functions: Array<{ id, name, module }> }— every server function the client compile emitted a reference to, by wire id.Build tooling that needs the client-reachable set reads it from here instead of re-deriving it from compiled output. The consumer this was built for is
@solidjs/prerender's static-mode guard: after a prerender crawl, any id infunctionsthat noprerendered()call captured is a call a static deployment cannot answer, and the build fails naming it.PersistedServerFunctionManifest.Changeset included (patch).
Made with Cursor