Skip to content

feat: include server function id in the request URL - #2251

Closed
birkskyum wants to merge 2 commits into
solidjs:mainfrom
birkskyum:fix-issue-1795
Closed

feat: include server function id in the request URL#2251
birkskyum wants to merge 2 commits into
solidjs:mainfrom
birkskyum:fix-issue-1795

Conversation

@birkskyum

Copy link
Copy Markdown
Member

Closes #1795

Server function calls all went to a single _server URL, so access logs, traces and the network panel collapsed every function into one entry.

Requests now go to _server/<id>. In development the id ends with the source name, so you get POST /_server/13375fbc-0-ping with no configuration.

Production ids stay opaque by default. Opt in to keep the names:

solidStart({ serverFunctions: { readableIds: true } })

Notes:

  • action.url changes from /_server?id=<id> to /_server/<id>. The handler still accepts the ?id= form, so hand-written URLs keep working.
  • The route check was pathname.startsWith("/_server"), which also matched unrelated routes like /_serverless. It is now an exact match on /_server or a /_server/ prefix.

Tested: 12 new unit tests for the URL helpers, both e2e suites pass (30/30 dev, 30/30 bundled-dev), and verified against a production build that the new URL, the legacy ?id= URL, and readableIds all behave as expected.

@changeset-bot

changeset-bot Bot commented Jul 26, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f9b7211

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/start Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Jul 26, 2026

Copy link
Copy Markdown

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit f9b7211
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/6a68cc556cccf3000844d285
😎 Deploy Preview https://deploy-preview-2251--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new

pkg-pr-new Bot commented Jul 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@solidjs/start@2251

commit: f9b7211

@birkskyum birkskyum added the Start 2.x targeting SolidStart 2.x versions label Jul 26, 2026
@lxsmnsyc

Copy link
Copy Markdown
Member

Hmmm this needs discussion. Pre-1.0 we had this kind of format then shifted to what we have today. I'm honestly fine with this change, but perhaps @ryansolid can weigh in on this

@birkskyum

birkskyum commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

This issue has already waited for an opinion from Ryan for over a year... so it's not something we can hold back a release of Start 2 for. Closing for now.

@birkskyum birkskyum closed this Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Start 2.x targeting SolidStart 2.x versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature?]: show function name in _server routes

2 participants