fix: end route module ids in the source extension so unplugin filters match - #2242
fix: end route module ids in the source extension so unplugin filters match#2242birkskyum wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: ccfd266 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
|
Superseded by #2249, which landed the same fix on That leaves nothing here but a changeset, which is now #2254. #1374 (the |
Route files are requested with a
?pick=...query, leaving ids likesrc/routes/index.tsx?pick=default&pick=$css. That does not end in.tsx, so plugins filtering with an end-anchored extension regex (/\.[jt]sx?$/, the default inunplugin-auto-importand friends) silently skip every route file.The query now ends with
&lang.<ext>, the same convention@vitejs/plugin-vueuses for?vue&type=script&lang.ts. The three places that built this string share atoRouteModuleId()helper.That change moves the query into Rollup's chunk base name, so
sanitizeRouteChunkNamestrips it back off viaoutput.sanitizeFileName. Output filenames are unchanged from before this PR.Verified with stock
AutoImport({ dirs: [...] })and noincludeoverride: the import is now injected into route chunks, in both build and dev. Existing suites pass (64 unit, 30 e2e, 30 bundled-dev), all fixtures build.