-
Notifications
You must be signed in to change notification settings - Fork 14
Add Issuer Trust to Security Considerations #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jeswr
wants to merge
1
commit into
main
Choose a base branch
from
feat/security-issuer-trust
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+18
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -525,6 +525,24 @@ data leaks should an attacker gain access to Client credentials. | |||||||||||||||||||||
| Clients are ephemeral, client registration is optional, and most Clients cannot keep secrets. These, | ||||||||||||||||||||||
| among other factors, are what makes Client trust challenging. | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| ## Issuer Trust ## {#security-issuer-trust} | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| *This section is non-normative* | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| A Solid-OIDC user's identity is asserted by the OpenID Provider listed in their WebID Profile via | ||||||||||||||||||||||
| `solid:oidcIssuer`. Implementers and end-users should consider the trust they place in that issuer: | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| * **Issuer trust is unconditional.** Every assertion of the user's identity comes from the issuer. | ||||||||||||||||||||||
| The user is fully reliant on it; a compromised, malicious, or unavailable issuer can deny access | ||||||||||||||||||||||
| to all of the user's data, impersonate the user, or selectively rewrite the WebID's | ||||||||||||||||||||||
| identity-related claims. A high degree of trust in the chosen issuer is therefore necessary. | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||||
| * **Many agents on a single issuer is a single point of failure.** Where many agents share a single | ||||||||||||||||||||||
| issuer, that issuer is a concentration point: a single compromise, outage, or service-level | ||||||||||||||||||||||
| decision affects every agent that depends on it. Attacks tend to focus on major centralisations, | ||||||||||||||||||||||
| so concentration risk grows with the issuer's user base. Implementations offering accounts under | ||||||||||||||||||||||
| a shared issuer should plan for this risk. | ||||||||||||||||||||||
|
Comment on lines
+540
to
+544
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||||
|
|
||||||||||||||||||||||
| # Privacy Considerations # {#privacy} | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| ## OIDC ID Token Reuse ## {#privacy-token-reuse} | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.