MPT-21552 derive order asset e2e fixtures from created order#339
Merged
Conversation
📝 WalkthroughWalkthroughThis PR refactors the E2E test fixtures for order assets by consolidating the ChangesOrder Asset Test Fixture Consolidation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Refactor the commerce order asset e2e fixtures to build the asset request from a real created order instead of many hard-coded fixture values. `order_asset_factory` now takes an `order` argument and reads its lines, id, product, and seller, and `created_order` is moved to the order-level conftest so it can be shared by both order and asset tests. Both the sync and async asset suites build their `created_order_asset` fixture from the created order, and the asset tests scope their requests by the created order's id instead of a hard-coded draft order id, so they operate on the order the asset actually belongs to. This keeps the asset fixture data consistent with the order it belongs to and avoids drift between separately maintained fixtures. Refs MPT-21552.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/e2e/commerce/order/asset/conftest.py`:
- Line 27: Replace the fragile name-based filter for asset_lines with a stable
check for the technical marker: build asset_lines using [line for line in
order["lines"] if line.get("period") == "one-time"] (or line.get("item",
{}).get("period") if period sits under item) instead of "Asset" in
line["item"]["name"], and add a fail-fast assertion (e.g., assert asset_lines,
"no asset lines found") so the test errors clearly if none are present.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 96b913e1-0d85-48d5-8280-9b8685b29a77
📒 Files selected for processing (6)
pyproject.tomltests/e2e/commerce/order/asset/conftest.pytests/e2e/commerce/order/asset/test_async_asset.pytests/e2e/commerce/order/asset/test_sync_asset.pytests/e2e/commerce/order/conftest.pytests/e2e/commerce/order/test_sync_order.py
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
softwareone-platform/mpt-extension-skills(manual)
💤 Files with no reviewable changes (1)
- tests/e2e/commerce/order/test_sync_order.py
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🧰 Additional context used
📓 Path-based instructions (2)
**/*
⚙️ CodeRabbit configuration file
**/*: For each subsequent commit in this PR, explicitly verify if previous review comments have been resolved
Files:
pyproject.tomltests/e2e/commerce/order/conftest.pytests/e2e/commerce/order/asset/test_async_asset.pytests/e2e/commerce/order/asset/conftest.pytests/e2e/commerce/order/asset/test_sync_asset.py
**
⚙️ CodeRabbit configuration file
**: # AGENTS.mdWorking protocol for any task in this repository:
- Identify the task type and select only the local repository files that are relevant to that task.
- Read only those relevant local files before making changes.
- If any selected local file references shared standards or shared operational guidance that are relevant to the same task, read those shared documents too before proceeding.
- Treat repository-local documents as repository-specific additions, restrictions, or overrides to shared guidance.
- If a repository-local rule conflicts with a shared rule, the local repository rule takes precedence.
Python API client for the SoftwareONE Marketplace Platform (MPT) API. Provides synchronous
(MPTClient) and asynchronous (AsyncMPTClient) clients built on httpx, with typed
resource services, mixin-based HTTP operations, and an RQL query builder.Documentation Reading Order
When applicable, read the repository documentation in this order:
README.md— repository overview, quick start, and documentation mapdocs/usage.md— installation, configuration, Python usage examples, and supported Docker-based commandsdocs/architecture.md— layered architecture, directory structure, and key abstractionsdocs/local-development.md— Docker-only setup and execution modeldocs/testing.md— repository-specific testing strategy and command mappingdocs/contributing.md— repository-specific workflow and links to shared standardsdocs/documentation.md— repository-specific documentation rulesThen inspect the code paths relevant to the task:
mpt_api_client/mpt_client.py— public sync and async client entry pointsmpt_api_client/http/— HTTP clients, services, query state, and reusable mixinsmpt_api_client/resources/— domain resource groups such as catalog, commerce, billing, and integrationmpt_api_client/models/— response model layer and collection wrappersmpt_api_client/rql/— fluent RQL query ...
Files:
pyproject.tomltests/e2e/commerce/order/conftest.pytests/e2e/commerce/order/asset/test_async_asset.pytests/e2e/commerce/order/asset/conftest.pytests/e2e/commerce/order/asset/test_sync_asset.py
🧠 Learnings (8)
📚 Learning: 2025-12-12T15:02:20.732Z
Learnt from: robcsegal
Repo: softwareone-platform/mpt-api-python-client PR: 160
File: tests/e2e/commerce/agreement/attachment/test_async_agreement_attachment.py:55-58
Timestamp: 2025-12-12T15:02:20.732Z
Learning: In pytest with pytest-asyncio, if a test function uses async fixtures but contains no await, declare the test function as def (synchronous) instead of async def. Pytest-asyncio will resolve the async fixtures automatically; this avoids linter complaints about unnecessary async functions. This pattern applies to any test file under the tests/ directory that uses such fixtures.
Applied to files:
tests/e2e/commerce/order/conftest.pytests/e2e/commerce/order/asset/test_async_asset.pytests/e2e/commerce/order/asset/conftest.pytests/e2e/commerce/order/asset/test_sync_asset.py
📚 Learning: 2026-04-02T09:35:03.825Z
Learnt from: jentyk
Repo: softwareone-platform/mpt-api-python-client PR: 269
File: tests/e2e/helpdesk/chats/links/test_sync_links.py:18-18
Timestamp: 2026-04-02T09:35:03.825Z
Learning: In this repository’s test suite, flake8-aaa/flake8-aaa codes use short two-digit suffixes (e.g., `# noqa: AAA01`), not three-digit variants like `AAA001`. If you see `# noqa: AAA01` in a test file (e.g., when the Act step is performed via a pytest fixture rather than inline code), treat it as valid and intentional—do not flag it as an invalid/no-longer-needed noqa, and do not suggest removing it even if Ruff reports `RUF102`, since `AAA` is configured under `tool.ruff.lint.external` and these noqa directives are expected to be preserved.
Applied to files:
tests/e2e/commerce/order/conftest.pytests/e2e/commerce/order/asset/test_async_asset.pytests/e2e/commerce/order/asset/conftest.pytests/e2e/commerce/order/asset/test_sync_asset.py
📚 Learning: 2026-01-08T08:34:05.465Z
Learnt from: albertsola
Repo: softwareone-platform/mpt-api-python-client PR: 183
File: tests/e2e/catalog/price_lists/conftest.py:29-30
Timestamp: 2026-01-08T08:34:05.465Z
Learning: In end-to-end tests (e.g., tests/e2e/...), reuse existing API resources for read-only operations and safe mutations to speed up test execution. Reserve isolated fixtures (e.g., created_price_list) for destructive tests that require per-test creation and cleanup. Ensure tests document when a fixture creates/destroys data and clearly indicate which operations are destructive, so tests stay fast and properly isolated.
Applied to files:
tests/e2e/commerce/order/conftest.pytests/e2e/commerce/order/asset/test_async_asset.pytests/e2e/commerce/order/asset/conftest.pytests/e2e/commerce/order/asset/test_sync_asset.py
📚 Learning: 2026-01-08T23:38:19.565Z
Learnt from: robcsegal
Repo: softwareone-platform/mpt-api-python-client PR: 186
File: tests/e2e/billing/ledger/charge/test_sync_ledger_charge.py:33-39
Timestamp: 2026-01-08T23:38:19.565Z
Learning: In Python e2e tests under tests/e2e, hardcoded external IDs (e.g., INV12345) are intentional because they come from seeded test data. Ensure the test data seeds consistently include these IDs; if seeds change, update tests accordingly. Prefer using a named constant for such IDs (e.g., INV_EXTERNAL_ID) and document the dependency on seed data to avoid brittle tests.
Applied to files:
tests/e2e/commerce/order/conftest.pytests/e2e/commerce/order/asset/test_async_asset.pytests/e2e/commerce/order/asset/conftest.pytests/e2e/commerce/order/asset/test_sync_asset.py
📚 Learning: 2026-02-02T13:05:41.144Z
Learnt from: albertsola
Repo: softwareone-platform/mpt-api-python-client PR: 201
File: tests/unit/resources/accounts/mixins/test_activatable_mixin.py:132-139
Timestamp: 2026-02-02T13:05:41.144Z
Learning: In the mpt-api-python-client repository, tests are configured to use pytest asyncio mode auto, which auto-detects async test functions and runs them without requiring pytest.mark.asyncio. Reviewers should rely on this behavior for all Python test files under tests/, and avoid adding unnecessary asyncio markers in async tests. Ensure test files in tests/ adhere to this convention unless a specific test requires an explicit marker.
Applied to files:
tests/e2e/commerce/order/conftest.pytests/e2e/commerce/order/asset/test_async_asset.pytests/e2e/commerce/order/asset/conftest.pytests/e2e/commerce/order/asset/test_sync_asset.py
📚 Learning: 2026-04-02T16:26:46.138Z
Learnt from: albertsola
Repo: softwareone-platform/mpt-api-python-client PR: 275
File: tests/e2e/exchange/currencies/conftest.py:43-43
Timestamp: 2026-04-02T16:26:46.138Z
Learning: In this repo’s Python E2E conftest files, line-specific flake8/wemake suppressions like `# noqa: WPS421` placed inline on individual statements (e.g., on specific `print()` calls in teardown blocks) are intentional and acceptable. When reviewing, avoid suggesting converting these to a file-wide ignore (e.g., adding per-file ignores under `[tool.flake8]` in `pyproject.toml`), since that would over-suppress WPS421 for the entire file. Also treat Ruff `RUF102` about an unknown rule code as expected here when suppressing `WPS421` from wemake-python-styleguide.
Applied to files:
tests/e2e/commerce/order/conftest.pytests/e2e/commerce/order/asset/conftest.py
📚 Learning: 2026-04-06T09:03:34.466Z
Learnt from: albertsola
Repo: softwareone-platform/mpt-api-python-client PR: 277
File: tests/e2e/extensibility/extensions/conftest.py:37-40
Timestamp: 2026-04-06T09:03:34.466Z
Learning: In this repo’s E2E test conftest teardown fixtures, it is intentional to catch `MPTAPIError` broadly (not just 404) and to print a diagnostic message instead of re-raising. This avoids failing the test suite during teardown when a resource cannot be deleted in some scenarios. Do not recommend narrowing the `except` clause in these teardown blocks (e.g., checking `error.status == 404`), unless the fixture is clearly not intended as an E2E teardown diagnostic.
Applied to files:
tests/e2e/commerce/order/conftest.pytests/e2e/commerce/order/asset/conftest.py
📚 Learning: 2026-04-16T13:00:41.320Z
Learnt from: jentyk
Repo: softwareone-platform/mpt-api-python-client PR: 303
File: tests/e2e/helpdesk/chats/participants/conftest.py:25-31
Timestamp: 2026-04-16T13:00:41.320Z
Learning: In mpt-api-python-client, do not treat list-wrapped arguments to CreateMixin.create() / AsyncCreateMixin.create() as an error. ResourceData is intentionally typed as Resource | list[Resource] (see mpt_api_client/models/model.py), so create() should accept either a single resource dict or a list of resource dicts (e.g., create([chat_participant_data])) to perform a batch create and return a ModelCollection. Therefore, reviewers should only flag list-wrapped create() arguments when there is evidence they violate the expected API contract beyond this documented batch-create behavior.
Applied to files:
tests/e2e/commerce/order/conftest.pytests/e2e/commerce/order/asset/test_async_asset.pytests/e2e/commerce/order/asset/conftest.pytests/e2e/commerce/order/asset/test_sync_asset.py
🔇 Additional comments (4)
pyproject.toml (1)
138-139: LGTM!tests/e2e/commerce/order/conftest.py (1)
10-15: LGTM!Also applies to: 20-25, 64-78
tests/e2e/commerce/order/asset/test_async_asset.py (1)
29-33: LGTM!Also applies to: 37-42, 46-50, 57-60, 66-70, 90-99, 107-114, 120-126
tests/e2e/commerce/order/asset/test_sync_asset.py (1)
29-34: LGTM!Also applies to: 38-40, 47-50, 58-61, 67-70, 91-99, 108-114, 121-126
Member
Author
|
@coderabbitai approve |
✅ Action performedComments resolved and changes approved. |
robcsegal
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI-generated PR — Please review carefully.
What
Refactor the commerce order asset e2e fixtures and tests (sync and async) to build the
asset request from a real created order instead of hard-coded fixture/config values.
order_asset_factorynow takes anorderargument and derives the asset lines, order id,product, and seller from it.
created_ordermoved to the order-level conftest so it is shared by both order and assettests;
order_factorynow also emits an asset line.created_order_assetfixtures build their request fromcreated_order.created_order.id(the order the asset actuallybelongs to) instead of the hard-coded
commerce_asset_draft_order_id. The endpoint is/public/v1/commerce/orders/{order_id}/assets, so the old scope pointed at a different orderand caused
404s (andtest_filter_order_assetsto fail itslen(result) == 1assertion).Why
Keeps the asset fixture data consistent with the order it belongs to and avoids drift between
separately maintained fixtures.
Testing
pre-commit(ruff, flake8 / wemake-python-styleguide, mypy) passes on the changed files.runs in CI.
Refs MPT-21552.
Closes MPT-21552
order_asset_factoryto accept anorderargument and derive asset lines, order ID, product, and seller from the provided order instead of accepting multiple hard-coded ID fixturescreated_orderfixture fromtests/e2e/commerce/order/test_sync_order.pytotests/e2e/commerce/order/conftest.pyto be shared between order and asset testsorder_factoryto include an asset line in order payloads, ensuring orders created for testing contain both commerce and asset itemscreated_order_assetfixtures to construct asset requests from the sharedcreated_orderfixturecreated_order.idinstead of hard-codedcommerce_asset_draft_order_id, resolving 404 errors and test failurescreated_orderand scope asset operations through the created orderper-file-ignoresconfiguration fortests/e2e/commerce/order/*.pyandtests/e2e/commerce/order/asset/*.pyto handle style violations in refactored code