Skip to content

MPT-21557 handle orphaned parameter during parameter creation in sync and async tests #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jentyk merged 1 commit into from
Jun 8, 2026
Merged

MPT-21557 handle orphaned parameter during parameter creation in sync and async tests #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/e2e/program/program/parameter/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import pytest

EXTERNAL_ID = "e2eCreatedProgramParameter"


@pytest.fixture
def parameter_id(e2e_config):
Expand All @@ -14,7 +16,7 @@ def invalid_parameter_id():
@pytest.fixture
def parameter_data():
return {
"externalId": "e2eCreatedProgramParameter",
"externalId": EXTERNAL_ID,
"displayOrder": 100,
"scope": "Enrollment",
"phase": "Fulfillment",
Expand Down
15 changes: 14 additions & 1 deletion tests/e2e/program/program/parameter/test_async_parameter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,27 @@

from mpt_api_client.exceptions import MPTAPIError
from mpt_api_client.rql.query_builder import RQLQuery
from tests.e2e.program.program.parameter.conftest import EXTERNAL_ID

pytestmark = [pytest.mark.flaky]


@pytest.fixture
async def created_parameter(async_mpt_vendor, program_id, parameter_data):
service = async_mpt_vendor.program.programs.parameters(program_id)
parameter = await service.create(parameter_data)
try:
parameter = await service.create(parameter_data)
except MPTAPIError as error:
if (
error.status_code == 400
and error.detail
and f"Parameter with given external identifier '{EXTERNAL_ID}' already "
"exists for given program."
in error.detail
):
parameter = await service.filter(RQLQuery(externalId=EXTERNAL_ID)).fetch_one()
else:
raise
Comment thread
jentyk marked this conversation as resolved.
yield parameter
try:
await service.delete(parameter.id)
Expand Down
15 changes: 14 additions & 1 deletion tests/e2e/program/program/parameter/test_sync_parameter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,27 @@

from mpt_api_client.exceptions import MPTAPIError
from mpt_api_client.rql.query_builder import RQLQuery
from tests.e2e.program.program.parameter.conftest import EXTERNAL_ID

pytestmark = [pytest.mark.flaky]


@pytest.fixture
def created_parameter(mpt_vendor, program_id, parameter_data):
service = mpt_vendor.program.programs.parameters(program_id)
parameter = service.create(parameter_data)
try:
parameter = service.create(parameter_data)
except MPTAPIError as error:
if (
error.status_code == 400
and error.detail
and f"Parameter with given external identifier '{EXTERNAL_ID}' already "
"exists for given program."
in error.detail
):
parameter = service.filter(RQLQuery(externalId=EXTERNAL_ID)).fetch_one()
else:
raise
yield parameter
try:
service.delete(parameter.id)
Expand Down