Skip to content

MPT-21555: Add shortDescription to queue_data function#330

Closed
javitrln wants to merge 1 commit into
mainfrom
fix/MPT-21555-fix-create-queue-issue
Closed

MPT-21555: Add shortDescription to queue_data function#330
javitrln wants to merge 1 commit into
mainfrom
fix/MPT-21555-fix-create-queue-issue

Conversation

@javitrln

@javitrln javitrln commented May 28, 2026

Copy link
Copy Markdown

JIRA Ticket: https://softwareone.atlassian.net/browse/MPT-21555

Add "short description" as it is mandatory field when creating queues.

Closes MPT-21555

  • Added shortDescription field to the queue_data fixture in tests/e2e/helpdesk/conftest.py to include the mandatory field required when creating queues

Review Change Stack

@javitrln javitrln requested a review from a team as a code owner May 28, 2026 14:15
@javitrln javitrln requested review from alephsur and svazquezco May 28, 2026 14:15
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

The queue_data fixture in the helpdesk E2E test configuration is updated to include a shortDescription field in its returned queue payload. This single-line change adds test data that reflects an expected field in the queue object.

Changes

Test fixture update

Layer / File(s) Summary
Queue fixture shortDescription field
tests/e2e/helpdesk/conftest.py
The queue_data fixture now includes a "shortDescription": "E2E Created Queue" field in its returned queue dictionary.

🎯 1 (Trivial) | ⏱️ ~2 minutes


Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Jira Issue Key In Title ❌ Error PR title "Add shortDescription to queue_data function" does not contain a Jira issue key in the format MPT-XXXX. Update PR title to include the Jira issue key, e.g., "MPT-21555: Add shortDescription to queue_data function"
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Test Coverage Required ✅ Passed PR modifies 194 code files in mpt_api_client/ but also includes 525 test file changes in tests/ folder, including the tests/e2e/helpdesk/conftest.py fixture modification.
Single Commit Required ✅ Passed PR contains exactly 1 commit (648eb7a: Add shortDescription to queue_data function), meeting the single commit requirement.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Actionable comments posted: 0

@javitrln javitrln changed the title Add shortDescription to queue_data function MPT-21555: Add shortDescription to queue_data function May 28, 2026
@d3rky

d3rky commented May 28, 2026

Copy link
Copy Markdown
Contributor

Backward incompatible changes on the API should be fixed on API side, not on the client side

@d3rky d3rky closed this May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants