[Tests] Add timer e2e test - #4437
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan includes up to 8 reviews per rolling hour; 3 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe timer example now logs gesture lifecycle callbacks, displays rounded press durations, and exposes a testable timer box. The end-to-end flow verifies initial state, two- and four-second holds, and a short tap. ChangesTimer gesture behavior
Sequence Diagram(s)sequenceDiagram
participant User
participant TimerExample
participant useIndexedLogger
participant scheduleOnRN
participant TimerUI
User->>TimerExample: Press or tap timer box
TimerExample->>useIndexedLogger: Log gesture lifecycle event
TimerExample->>scheduleOnRN: Schedule rounded duration update
scheduleOnRN->>TimerExample: Update lastPress state
TimerExample->>TimerUI: Render last press duration
Merge Risk: ⚪ Minimal · up to This PR adds a timer end-to-end test flow and updates the Timer example; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
## Description Updates `Timer` example and adds an e2e argent flow ## Test plan `argent flow run timer-test`
d27999a to
a9beeb8
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the “Timer” v3 example screen in apps/common-app to surface deterministic UI signals (testIDs + “Last press” summary) and adds a new Argent E2E flow that exercises long-press timing and log ordering via the in-app console.
Changes:
- Update the Timer showcase example to log gesture lifecycle events and display the last measured press duration (rounded to whole seconds) with stable
testIDs for automation. - Add a new Argent flow (
timer-test.yaml) that navigates to the Timer example, performs timed long-presses/taps, and asserts both UI output and console log ordering.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/common-app/src/new_api/showcase/timer/index.tsx | Adds indexed gesture lifecycle logging, stable testIDs, and a “Last press” duration summary updated from a worklet via scheduleOnRN. |
| .argent/flows/timer-test.yaml | Introduces an E2E flow validating Timer behavior (duration summary + ordered console logs) across multiple interactions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Description
Updates
Timerexample and adds an e2e argent flowTest plan
argent flow run timer-test