Skip to content

[Android] Remove old Reanimated check - #4431

Merged
m-bert merged 1 commit into
mainfrom
@mbert/reanimated-check
Aug 17, 2026
Merged

[Android] Remove old Reanimated check#4431
m-bert merged 1 commit into
mainfrom
@mbert/reanimated-check

Conversation

@m-bert

@m-bert m-bert commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Description

Removes stale check for Reanimated 2.3.x, leaving only 3.x+

Test plan

Build basic-example

Copilot AI lite review requested due to automatic review settings August 17, 2026 06:39
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 294a4b11-9d62-4f95-b0d0-dd4322a31d00

📥 Commits

Reviewing files that changed from the base of the PR and between 3e4497e and f5d1760.

📒 Files selected for processing (1)
  • packages/react-native-gesture-handler/android/build.gradle

Included review availability: Your plan includes up to 8 reviews per rolling hour; 7 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Updated Reanimated compatibility handling to use the common interface for all version 3 and newer releases.

Walkthrough

The Android build configuration now enables the Reanimated common interface only for major version 3 and later. It also removes an obsolete compatibility comment.

Changes

Reanimated compatibility

Layer / File(s) Summary
Update Reanimated version detection
packages/react-native-gesture-handler/android/build.gradle
shouldUseCommonInterfaceFromReanimated() now accepts Reanimated major version 3 and later. The obsolete Reanimated 2.3 compatibility comment was removed.

Suggested reviewers: hurali97

Merge Risk: ⚪ Minimal · up to f5d17

This is a localized removal of a stale Android build check, with no actionable merge-blocking risk remaining after normal checks and review.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the removal of the outdated Android Reanimated compatibility check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Android Gradle build logic in react-native-gesture-handler to remove the legacy Reanimated 2.3+ compatibility check and gate the “common interface” integration behind Reanimated 3.x+ only.

Changes:

  • Simplifies the Reanimated integration condition on Android from (2.3+ or 3+) to 3+ only.
  • Removes the now-stale comment describing the old Reanimated 2.3+ threshold.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines 104 to +106
def (major, minor, patch) = getExternalLibVersion(reanimated)

return (major == 2 && minor >= 3) || major >= 3
return major >= 3
@m-bert
m-bert merged commit b2d23f1 into main Aug 17, 2026
5 checks passed
@m-bert
m-bert deleted the @mbert/reanimated-check branch August 17, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants