[Android] Remove old Reanimated check - #4431
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 8 reviews per rolling hour; 7 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Android build configuration now enables the Reanimated common interface only for major version 3 and later. It also removes an obsolete compatibility comment. ChangesReanimated compatibility
Suggested reviewers: Merge Risk: ⚪ Minimal · up to This is a localized removal of a stale Android build check, with no actionable merge-blocking risk remaining after normal checks and review. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the Android Gradle build logic in react-native-gesture-handler to remove the legacy Reanimated 2.3+ compatibility check and gate the “common interface” integration behind Reanimated 3.x+ only.
Changes:
- Simplifies the Reanimated integration condition on Android from
(2.3+ or 3+)to3+only. - Removes the now-stale comment describing the old Reanimated
2.3+threshold.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| def (major, minor, patch) = getExternalLibVersion(reanimated) | ||
|
|
||
| return (major == 2 && minor >= 3) || major >= 3 | ||
| return major >= 3 |
Description
Removes stale check for Reanimated 2.3.x, leaving only 3.x+
Test plan
Build basic-example