-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[Tests] Add nested touchables e2e test #4426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
j-piasecki
merged 1 commit into
jpiasecki/e2e-basic-long-press
from
jpiasecki/e2e-nested-touchables
Aug 18, 2026
+230
−76
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| steps: | ||
| - echo: Launching Expo Example | ||
| - launch: com.example.ExpoExample | ||
| - await: { visible: { text: "Empty Example" }, timeout: 15000 } | ||
| - echo: "On the Home list, search for the nested touchables example" | ||
| - type: { text: "nested touchables", into: { id: "search-examples" } } | ||
| - echo: "Tap the example to open it" | ||
| - tap: { text: "Nested touchables" } | ||
| - await: { visible: { id: "level-4" } } | ||
| - await: { idle: true } | ||
|
|
||
| - echo: "Clear console" | ||
| - await: { visible: { id: "open-console-button" } } | ||
| - tap: { id: "open-console-button" } | ||
| - await: { visible: { id: "clear-console-button" } } | ||
| - tap: { id: "clear-console-button" } | ||
| - tap: { id: "close-console-button" } | ||
| - await: { idle: true } | ||
|
|
||
| - echo: "Level 1 - tap the outer tap gesture" | ||
| - tap: { id: "level-1" } | ||
| - tap: { id: "open-console-button" } | ||
| - await: { idle: true } | ||
| - await: { visible: { id: "close-console-button" } } | ||
| - echo: "Level 1 activates and no other level logs" | ||
| - assert: { visible: { text: "1. L1 onActivate" } } | ||
| - assert: { hidden: { text: "L2 on" } } | ||
| - assert: { hidden: { text: "L3 on" } } | ||
| - assert: { hidden: { text: "L4 on" } } | ||
| - assert: { hidden: { text: "2. L" } } | ||
|
|
||
| - echo: "Clear console" | ||
| - tap: { id: "clear-console-button" } | ||
| - tap: { id: "close-console-button" } | ||
| - await: { idle: true } | ||
|
|
||
| - echo: "Level 2 - tap the touchable nested in the outer tap gesture" | ||
| - tap: { id: "level-2" } | ||
| - tap: { id: "open-console-button" } | ||
| - await: { idle: true } | ||
| - await: { visible: { id: "close-console-button" } } | ||
| - echo: "Level 2 presses in order and no other level logs" | ||
| - assert: { visible: { text: "2. L2 onPressIn" } } | ||
| - assert: { visible: { text: "3. L2 onPressOut" } } | ||
| - assert: { visible: { text: "4. L2 onPress" } } | ||
| - assert: { hidden: { text: "L1 on" } } | ||
| - assert: { hidden: { text: "L3 on" } } | ||
| - assert: { hidden: { text: "L4 on" } } | ||
| - assert: { hidden: { text: "5. L" } } | ||
|
|
||
| - echo: "Clear console" | ||
| - tap: { id: "clear-console-button" } | ||
| - tap: { id: "close-console-button" } | ||
| - await: { idle: true } | ||
|
|
||
| - echo: "Level 3 - tap the tap gesture nested in the touchable" | ||
| - tap: { id: "level-3" } | ||
| - tap: { id: "open-console-button" } | ||
| - await: { idle: true } | ||
| - await: { visible: { id: "close-console-button" } } | ||
| - echo: "Level 3 activates and no other level logs" | ||
| - assert: { visible: { text: "5. L3 onActivate" } } | ||
| - assert: { hidden: { text: "L1 on" } } | ||
| - assert: { hidden: { text: "L2 on" } } | ||
| - assert: { hidden: { text: "L4 on" } } | ||
| - assert: { hidden: { text: "6. L" } } | ||
|
|
||
| - echo: "Clear console" | ||
| - tap: { id: "clear-console-button" } | ||
| - tap: { id: "close-console-button" } | ||
| - await: { idle: true } | ||
|
|
||
| - echo: "Level 4 - tap the innermost touchable" | ||
| - tap: { id: "level-4" } | ||
| - tap: { id: "open-console-button" } | ||
| - await: { idle: true } | ||
| - await: { visible: { id: "close-console-button" } } | ||
| - echo: "Level 4 presses in order and no other level logs" | ||
| - assert: { visible: { text: "6. L4 onPressIn" } } | ||
| - assert: { visible: { text: "7. L4 onPressOut" } } | ||
| - assert: { visible: { text: "8. L4 onPress" } } | ||
| - assert: { hidden: { text: "L1 on" } } | ||
| - assert: { hidden: { text: "L2 on" } } | ||
| - assert: { hidden: { text: "L3 on" } } | ||
| - assert: { hidden: { text: "9. L" } } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Make the level widths responsive.
level1has width340, but a 360-dp screen provides only 328 dp after the container padding. The level can overflow or clip. Use relative widths withmaxWidthvalues.Proposed fix
level1: { - width: 340, + width: '100%', + maxWidth: 340, backgroundColor: COLORS.KINDA_YELLOW, }, level2: { - width: 300, + width: '88%', + maxWidth: 300, backgroundColor: COLORS.YELLOW, }, level3: { - width: 260, + width: '87%', + maxWidth: 260, backgroundColor: COLORS.KINDA_GREEN, }, level4: { - width: 220, + width: '85%', + maxWidth: 220, backgroundColor: COLORS.KINDA_BLUE, },📝 Committable suggestion
🤖 Prompt for AI Agents