Skip to content

[General] Default GestureDetector moduleId to -1 #4412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-bert merged 2 commits into from
Aug 13, 2026
+3 −4
Merged

[General] Default GestureDetector moduleId to -1 #4412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dd3d8c
[General] Default GestureDetector moduleId to -1
kosmydel Aug 13, 2026
35c04d9
[Android] Skip native detector detach when the registry is missing
kosmydel Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .../android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerDetectorView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,8 +230,7 @@ class RNGestureHandlerDetectorView(context: Context) : ReactViewGroup(context) {
}

private fun detachNativeGestureHandlers() {
val registry = RNGestureHandlerModule.registries[moduleId]
?: throw Exception("Tried to access a non-existent registry")
val registry = RNGestureHandlerModule.registries[moduleId] ?: return

for (tag in nativeHandlers) {
if (!attachedHandlers.contains(tag)) {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-gesture-handler/src/specs/RNGestureHandlerDetectorNativeComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export interface NativeProps extends ViewProps {
| undefined;

handlerTags: CodegenTypes.Int32[];
moduleId: CodegenTypes.Int32;
moduleId?: CodegenTypes.WithDefault<CodegenTypes.Int32, -1>;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
virtualChildren: VirtualChildrenProps[];

pointerEvents?: CodegenTypes.WithDefault<
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-gesture-handler/src/specs/RNGestureHandlerRootViewNativeComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export interface RootViewNativeProps extends ViewProps {
}

interface NativeProps extends ViewProps {
moduleId: CodegenTypes.Int32;
moduleId?: CodegenTypes.WithDefault<CodegenTypes.Int32, -1>;
unstable_forceActive?: boolean;
}

Expand Down
Loading