Skip to content

Implement Pressable based on Touchable #4411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-bert merged 11 commits into from
Aug 13, 2026
Merged

Implement Pressable based on Touchable #4411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
86e5f3f
Pressable with Touchable
m-bert Aug 11, 2026
78a9070
unvibe comments
m-bert Aug 11, 2026
72a1242
typo
m-bert Aug 11, 2026
05639e3
Review + retention offset
m-bert Aug 11, 2026
65280de
Delay
m-bert Aug 11, 2026
cbf3a63
Rename
m-bert Aug 11, 2026
587cf4d
Don't use ref
m-bert Aug 11, 2026
b0f3623
Merge branch 'main' into @mbert/pressable-wrapper
m-bert Aug 11, 2026
17b6aec
Hover delay cancellation
m-bert Aug 13, 2026
dbfca04
cursor
m-bert Aug 13, 2026
cb144a3
Merge branch 'main' into @mbert/pressable-wrapper
m-bert Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/react-native-gesture-handler/src/__tests__/api_v3.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@
const panGesture = renderHook(() =>
usePanGesture({
disableReanimated: true,
onBegin: (e) => onBegin(e),

Check warning on line 58 in packages/react-native-gesture-handler/src/__tests__/api_v3.test.tsx

View workflow job for this annotation

GitHub Actions / check 

Unsafe return of an `any` typed value
onActivate: (e) => onStart(e),

Check warning on line 59 in packages/react-native-gesture-handler/src/__tests__/api_v3.test.tsx

View workflow job for this annotation

GitHub Actions / check 

Unsafe return of an `any` typed value
})
).result.current;

Expand Down Expand Up @@ -84,8 +84,8 @@
const panGesture = renderHook(() =>
usePanGesture({
disableReanimated: true,
onUpdate: (e) => onUpdate(e),

Check warning on line 87 in packages/react-native-gesture-handler/src/__tests__/api_v3.test.tsx

View workflow job for this annotation

GitHub Actions / check 

Unsafe return of an `any` typed value
onTouchesUp: (e) => onTouchesUp(e),

Check warning on line 88 in packages/react-native-gesture-handler/src/__tests__/api_v3.test.tsx

View workflow job for this annotation

GitHub Actions / check 

Unsafe return of an `any` typed value
})
).result.current;

Expand All @@ -102,7 +102,7 @@

expect(() => {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
jsEventHandler?.(malformedTouchEvent as any);

Check warning on line 105 in packages/react-native-gesture-handler/src/__tests__/api_v3.test.tsx

View workflow job for this annotation

GitHub Actions / check 

Unsafe argument of type `any` assigned to a parameter of type `GestureHandlerEventWithHandlerData<PanHandlerData, PanExtendedHandlerData>`
}).not.toThrow();

expect(onUpdate).not.toHaveBeenCalled();
Expand All @@ -115,7 +115,7 @@
const panGesture = renderHook(() =>
usePanGesture({
disableReanimated: true,
onUpdate: (e) => onUpdate(e),

Check warning on line 118 in packages/react-native-gesture-handler/src/__tests__/api_v3.test.tsx

View workflow job for this annotation

GitHub Actions / check 

Unsafe return of an `any` typed value
})
).result.current;

Expand Down Expand Up @@ -256,14 +256,14 @@

await act(flushImmediate);

const nativeDetector = getNativeDetector(UNSAFE_getAllByType);
const scrollViewResponder = getScrollViewResponder(UNSAFE_getAllByType);
const button = screen.getByTestId('pressable');

expect(scrollViewResponder).toBeDefined();
expect(
scrollViewResponder?.props.onStartShouldSetResponderCapture()
).toBe(false);
expect(nativeDetector?.props.onStartShouldSetResponder()).toBe(false);
expect(button.props.onStartShouldSetResponderCapture()).toBe(false);
expect(scrollViewResponder?.props.onStartShouldSetResponder()).toBe(true);
expect(scrollViewResponder?.props.onStartShouldSetResponder()).toBe(
false
Expand All @@ -281,13 +281,13 @@

await act(flushImmediate);

const nativeDetector = getNativeDetector(UNSAFE_getAllByType);
const scrollViewResponder = getScrollViewResponder(UNSAFE_getAllByType);
const button = screen.getByTestId('pressable');

// Outside of 'handled' mode the logical responder view is not rendered
// at all — the responder event can never be claimed on behalf of RNGH.
expect(scrollViewResponder).toBeUndefined();
expect(nativeDetector?.props.onStartShouldSetResponder()).toBe(false);
expect(button.props.onStartShouldSetResponderCapture()).toBe(false);
});

test('handles responder event passed through NativeDetector for keyboardShouldPersistTaps handled', async () => {
Expand Down
Loading
Loading