[CI] Upload application artifacts - #4378
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR converts Android and iOS build workflows into reusable ChangesCI Build Workflow Refactor
Sequence Diagram(s)sequenceDiagram
participant TriggerWorkflow
participant ReusableBuildWorkflow
participant BuildToolchain
participant ArtifactStorage
TriggerWorkflow->>ReusableBuildWorkflow: pass app-specific build inputs
ReusableBuildWorkflow->>BuildToolchain: install dependencies and build release artifact
BuildToolchain-->>ReusableBuildWorkflow: return APK or packaged iOS app
ReusableBuildWorkflow->>ArtifactStorage: upload artifact
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/android.yml:
- Around line 4-16: Update the pull_request paths filter in the Android workflow
to include source changes bundled by the Android build: add app-wide or explicit
source globs for apps/basic-example, apps/expo-example, and
packages/react-native-gesture-handler/src beyond the existing specs path, while
preserving the current workflow, native, and configuration entries.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: fab1a01d-8fbb-4882-9abc-79566e38e9a6
📒 Files selected for processing (4)
.github/workflows/android-build.yml.github/workflows/android.yml.github/workflows/ios-build.yml.github/workflows/ios.yml
There was a problem hiding this comment.
Pull request overview
Updates CI to build Android/iOS example apps via reusable workflows and upload the resulting application binaries as artifacts, enabling downstream jobs (e.g., future e2e) to reuse the exact built outputs without rebuilding.
Changes:
- Adds new top-level Android and iOS workflows that run an app build matrix and call reusable build workflows.
- Refactors Android/iOS build workflows into
workflow_call-based reusable workflows that build Release variants and upload artifacts (APK / tarred.app). - Adds iOS artifact packaging step that preserves executable permissions by uploading a tarball instead of a zip.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/ios.yml | Adds iOS matrix workflow that calls the reusable iOS build workflow and uploads per-app artifacts. |
| .github/workflows/ios-build.yml | Converts iOS build to a reusable workflow; builds Release simulator app and uploads a tarred .app artifact. |
| .github/workflows/android.yml | Adds Android matrix workflow that calls the reusable Android build workflow and uploads per-app artifacts. |
| .github/workflows/android-build.yml | Converts Android build to a reusable workflow; builds Release APK and uploads it as an artifact. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e483f5b to
c03d934
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
c03d934 to
2ca1cea
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ios-build.yml:
- Around line 39-44: Update the XCODE_APP availability check in the iOS build
workflow to fail immediately when the requested XCODE_VERSION is not installed.
Keep the diagnostic listing of available Xcode installations, then exit with a
nonzero status instead of selecting a fallback Xcode.app or continuing the
build.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9fb5151b-8bf2-43e3-9afe-1767489a424e
📒 Files selected for processing (7)
.github/workflows/android-basic.yml.github/workflows/android-build.yml.github/workflows/android.yml.github/workflows/ios-basic.yml.github/workflows/ios-build.yml.github/workflows/ios.yml.github/workflows/static-example-apps-checks.yml
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/android.yml
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Turn `android-build.yml` and `ios-build.yml` into reusable workflows driven by new `android.yml` / `ios.yml` entry points, and have them upload the app they built. Builds now run in Release for the simulator/emulator ABI, so the uploaded APK / .app bundle is exactly what a later job can install instead of building the app a second time.
2ca1cea to
ac25885
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/android-build.yml:
- Around line 42-53: Validate the app input before any install, build, or
artifact steps in .github/workflows/android-build.yml (lines 42-53) and
.github/workflows/ios-build.yml (lines 55-65 and 80), allowing only supported
values such as basic-example and expo-example and rejecting path separators or
all other values. Ensure every subsequent working-directory, Gradle/Xcode path,
and artifact path uses only the validated app value.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: f5a61508-5a1a-4e3f-b127-13c53e041acb
📒 Files selected for processing (7)
.github/workflows/android-basic.yml.github/workflows/android-build.yml.github/workflows/android.yml.github/workflows/ios-basic.yml.github/workflows/ios-build.yml.github/workflows/ios.yml.github/workflows/static-example-apps-checks.yml
🚧 Files skipped from review as they are similar to previous changes (5)
- .github/workflows/android.yml
- .github/workflows/android-basic.yml
- .github/workflows/ios.yml
- .github/workflows/ios-basic.yml
- .github/workflows/static-example-apps-checks.yml
ac25885 to
56ae3e9
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Description
Updates the CI:
Test plan
CI run