fix: normalizer does not strip br nodes inside blockquote - #720
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes HTML normalization so <br> elements inside <blockquote> are preserved (instead of being dropped), keeping empty-line spacing within blockquotes consistent across web and native normalization paths.
Changes:
- Update blockquote-flattening logic to emit a canonical
<br>when a<br>is encountered with no pending inline paragraph content. - Adjust existing normalization expectations to include
<br>inside blockquotes where appropriate. - Add targeted regression tests for
<br>between blockquote paragraphs (TypeScript + C++/Gumbo).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/web/normalization/htmlNormalizer.ts | Preserve <br> nodes during blockquote flattening by emitting <br> when no paragraph was flushed. |
| src/web/tests/htmlNormalizer.test.ts | Update expected output and add a regression test covering <br> between blockquote paragraphs. |
| cpp/parser/GumboNormalizer.c | Mirror the web normalizer behavior in the Gumbo-based native normalizer. |
| cpp/tests/GumboParserTest.cpp | Update expected output and add a regression test for the Gumbo normalizer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
exploIF
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
<br>was getting stripped when inside of a<blockquote>The example HTML that was reproducing the issue:
Screenshots
When setting the input's value with that HTML I mentioned in the summary.
Before:
After:
Compatibility
Checklist