Skip to content

feat: let a fresh js context resync with an ongoing native recording - #1235

Draft
mdydek wants to merge 1 commit into
feat/android-fgs-survive-task-removalfrom
feat/android-fgs-survive-task-removal2
Draft

feat: let a fresh js context resync with an ongoing native recording#1235
mdydek wants to merge 1 commit into
feat/android-fgs-survive-task-removalfrom
feat/android-fgs-survive-task-removal2

Conversation

@mdydek

@mdydek mdydek commented Aug 17, 2026

Copy link
Copy Markdown
Member

With stopWithTask=false a recording outlives the app UI, but a remounted screen (or relaunched app) had no way to learn about it — recorder state was only reachable through the instance that started it:

  • new JSI globals backed by ActiveRecorderHandle, surfaced as statics: AudioRecorder.isRecordingOngoing() and the consume-once AudioRecorder.takeLastRecordingResult() for files finalized by the notification stop action (mock parity + jest coverage included)
  • Record demo mounts directly in the live recorder's state, picks up natively stopped files, keeps the recording alive across screen exits and only enables file output when no session is ongoing (re-enabling mid-recording replaces the writer and resets the duration)
  • deep-link routing for the notification tap (react-navigation linking), duration displays seeded from the recorder instead of assuming a fresh session, and RecordingTime rewritten to plain state — the animated-prop binding went stale on the frozen value while paused and showed zeros

Closes #

⚠️ Breaking changes ⚠️

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web
  • Updated old arch android spec file

With stopWithTask=false a recording outlives the app UI, but a remounted
screen (or relaunched app) had no way to learn about it — recorder state was
only reachable through the instance that started it:

- new JSI globals backed by ActiveRecorderHandle, surfaced as statics:
  AudioRecorder.isRecordingOngoing() and the consume-once
  AudioRecorder.takeLastRecordingResult() for files finalized by the
  notification stop action (mock parity + jest coverage included)
- Record demo mounts directly in the live recorder's state, picks up
  natively stopped files, keeps the recording alive across screen exits and
  only enables file output when no session is ongoing (re-enabling
  mid-recording replaces the writer and resets the duration)
- deep-link routing for the notification tap (react-navigation linking),
  duration displays seeded from the recorder instead of assuming a fresh
  session, and RecordingTime rewritten to plain state — the animated-prop
  binding went stale on the frozen value while paused and showed zeros

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

WPT non-regression comparison

ERROR — the run produced no report.

Workflow run · this comment is updated on every push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant