feat: Souls - #2796
Open
reczkok wants to merge 1 commit into
Open
Conversation
Contributor
|
Run failed. View the logs →
|
|
pkg.pr.new packages benchmark commit |
Resolution Time Benchmark---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Random Branching (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.95, 1.90, 4.09, 6.14, 6.77, 11.48, 21.18, 22.33]
line [0.88, 1.79, 3.81, 6.07, 7.14, 11.48, 21.45, 22.61]
line [0.95, 1.92, 4.15, 6.31, 7.11, 10.61, 20.70, 22.32]
---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Linear Recursion (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.25, 0.47, 0.63, 0.76, 1.07, 1.10, 1.37, 1.53]
line [0.34, 0.47, 0.65, 0.86, 1.08, 1.16, 1.29, 1.44]
line [0.32, 0.54, 0.74, 0.87, 1.15, 1.21, 1.42, 1.59]
---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Full Tree (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.77, 1.99, 4.09, 7.49, 12.78, 24.45, 51.62, 104.21]
line [0.76, 2.07, 3.70, 6.60, 12.69, 24.49, 51.42, 105.14]
line [0.83, 2.15, 4.43, 7.18, 12.65, 26.09, 54.47, 111.06]
|
Bundle size comparison (
|
| 🟢 Decreased | ➖ Unchanged | 🔴 Increased (max 3.97%) | ❔ Unknown |
|---|---|---|---|
| 0 | 2 | 320 | 0 |
import * as ... in PR vs import * as ... in target (did bundle size increase?):
Click to reveal the results table (56 entries).
| Test | tsdown |
|---|---|
| d_Void.ts | 759 B ( |
| d_sampler.ts | 767 B ( |
| d_isPtr.ts | 777 B ( |
| d_comparisonSampler.ts | 778 B ( |
| d_isSizeAttrib.ts | 779 B ( |
| d_isWgslArray.ts | 779 B ( |
| d_isAlignAttrib.ts | 780 B ( |
| d_isAtomic.ts | 780 B ( |
| d_isWgslStruct.ts | 780 B ( |
| d_isBuiltinAttrib.ts | 782 B ( |
| d_isDecorated.ts | 783 B ( |
| d_isLocationAttrib.ts | 783 B ( |
| d_isInterpolateAttrib.ts | 786 B ( |
| d_atomic.ts | 804 B ( |
| d_ptrHandle.ts | 876 B ( |
| d_ptrUniform.ts | 877 B ( |
| d_ptrStorage.ts | 881 B ( |
| d_ptrPrivate.ts | 883 B ( |
| d_ptrFn.ts | 884 B ( |
| d_ptrWorkgroup.ts | 885 B ( |
| d_textureExternal.ts | 898 B ( |
| d_textureStorage1d.ts | 1.04 kB ( |
| d_textureStorage2d.ts | 1.04 kB ( |
| d_textureStorage3d.ts | 1.04 kB ( |
| d_textureStorage2dArray.ts | 1.05 kB ( |
| d_isDisarray.ts | 1.14 kB ( |
| d_isUnstruct.ts | 1.14 kB ( |
| d_isLooseDecorated.ts | 1.14 kB ( |
| d_isLooseData.ts | 1.18 kB ( |
| d_isWgslData.ts | 1.33 kB ( |
| d_unstruct.ts | 1.58 kB ( |
| d_isData.ts | 1.83 kB ( |
| d_deepEqual.ts | 2.22 kB ( |
| STATIC_tgpu.ts | 275.78 kB ( |
| tgpu_fn.ts | 275.78 kB ( |
| tgpu_init.ts | 275.78 kB ( |
| tgpu_lazy.ts | 275.78 kB ( |
| tgpu_slot.ts | 275.78 kB ( |
| tgpu_const.ts | 275.79 kB ( |
| tgpu_unroll.ts | 275.79 kB ( |
| tgpu_resolve.ts | 275.79 kB ( |
| tgpu_accessor.ts | 275.79 kB ( |
| tgpu_comptime.ts | 275.79 kB ( |
| tgpu_vertexFn.ts | 275.79 kB ( |
| tgpu_computeFn.ts | 275.79 kB ( |
| tgpu_fragmentFn.ts | 275.79 kB ( |
| tgpu_privateVar.ts | 275.79 kB ( |
| tgpu_vertexLayout.ts | 275.79 kB ( |
| tgpu_workgroupVar.ts | 275.79 kB ( |
| tgpu_initFromDevice.ts | 275.79 kB ( |
| tgpu_bindGroupLayout.ts | 275.79 kB ( |
| tgpu_mutableAccessor.ts | 275.79 kB ( |
| tgpu_resolveWithContext.ts | 275.80 kB ( |
| STATIC_allImports.ts | 301.55 kB ( |
| d_struct.ts | 3.64 kB ( |
| d_ref.ts | 4.92 kB ( |
import { ... } in PR vs import * as ... in PR (is the library tree-Shakeable?):
| Test | tsdown |
|---|---|
| tgpu_init.ts | 266.69 kB ( |
| tgpu_initFromDevice.ts | 266.16 kB ( |
| tgpu_resolve.ts | 167.70 kB ( |
| tgpu_resolveWithContext.ts | 167.63 kB ( |
| tgpu_bindGroupLayout.ts | 73.57 kB ( |
| tgpu_mutableAccessor.ts | 68.30 kB ( |
| tgpu_accessor.ts | 68.29 kB ( |
| tgpu_privateVar.ts | 66.85 kB ( |
| tgpu_workgroupVar.ts | 66.85 kB ( |
| tgpu_const.ts | 66.40 kB ( |
| tgpu_lazy.ts | 66.21 kB ( |
| tgpu_fragmentFn.ts | 38.72 kB ( |
| tgpu_fn.ts | 38.65 kB ( |
| tgpu_vertexFn.ts | 38.53 kB ( |
| tgpu_computeFn.ts | 38.24 kB ( |
| tgpu_vertexLayout.ts | 27.36 kB ( |
| tgpu_comptime.ts | 14.97 kB ( |
| tgpu_unroll.ts | 1.68 kB ( |
| tgpu_slot.ts | 1.63 kB ( |
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Groundwork for the transfer protocol (PR on top of this one). To move a resource between runtimes we need its complete definitional state as a plain serializable record, and previously that state was scattered across private fields, closures and getters per resource. This PR gathers it into one place without changing any behavior.
[$soul]- a plain record of everything that survives a device boundary (own data properties only, no methods, no prototype, no symbol keys)[$internal]changed fromtrueto an object exposingmaterialize(), which fills the soul'srawwith the device object for resources that own one (buffer, texture, query set, pipelines, ...)