Skip to content

fix: Global identifier inside nested function call #2789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cieplypolar wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Global identifier inside nested function call #2789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
065cf30
fix
cieplypolar Aug 5, 2026
58ffda7
review fixes
cieplypolar Aug 5, 2026
038b32a
Merge branch 'main' into fix/name-collision
cieplypolar Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions apps/typegpu-docs/tests/individual-example-tests/3d-fish.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,23 +63,23 @@ describe('3d fish example', () => {
return ((x << k) | (x >> (32u - k)));
}

var<private> seed: vec2f;
var<private> seed_1: vec2f;

fn seed2(value: vec2f) {
let scrambled = scrambleSeed2(value);
seed = ((vec2f(u32To01F32(hash((scrambled.x ^ scrambled.y))), u32To01F32(hash((rotl(scrambled.x, 16u) ^ scrambled.y)))) * 2f) - 1f);
seed_1 = ((vec2f(u32To01F32(hash((scrambled.x ^ scrambled.y))), u32To01F32(hash((rotl(scrambled.x, 16u) ^ scrambled.y)))) * 2f) - 1f);
}

fn randSeed2(seed: vec2f) {
seed2(seed);
}

fn sample() -> f32 {
let a = dot(seed, vec2f(23.140779495239258, 232.6168975830078));
let b = dot(seed, vec2f(54.47856521606445, 345.8415222167969));
seed.x = fract((cos(a) * 136.8168f));
seed.y = fract((cos(b) * 534.7645f));
return seed.y;
let a = dot(seed_1, vec2f(23.140779495239258, 232.6168975830078));
let b = dot(seed_1, vec2f(54.47856521606445, 345.8415222167969));
seed_1.x = fract((cos(a) * 136.8168f));
seed_1.y = fract((cos(b) * 534.7645f));
return seed_1.y;
}

fn randFloat01() -> f32 {
Expand Down
14 changes: 7 additions & 7 deletions apps/typegpu-docs/tests/individual-example-tests/caustics.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,23 +71,23 @@ describe('caustics example', () => {
return (f - 1f);
}

var<private> seed: vec2f;
var<private> seed_1: vec2f;

fn seed3(value: vec3f) {
let scrambled = scrambleSeed3(value);
seed = ((vec2f(u32To01F32(hash((scrambled.x ^ rotl(scrambled.z, 16u)))), u32To01F32(hash((rotl(scrambled.y, 16u) ^ scrambled.z)))) * 2f) - 1f);
seed_1 = ((vec2f(u32To01F32(hash((scrambled.x ^ rotl(scrambled.z, 16u)))), u32To01F32(hash((rotl(scrambled.y, 16u) ^ scrambled.z)))) * 2f) - 1f);
}

fn randSeed3(seed: vec3f) {
seed3(seed);
}

fn sample_1() -> f32 {
let a = dot(seed, vec2f(23.140779495239258, 232.6168975830078));
let b = dot(seed, vec2f(54.47856521606445, 345.8415222167969));
seed.x = fract((cos(a) * 136.8168f));
seed.y = fract((cos(b) * 534.7645f));
return seed.y;
let a = dot(seed_1, vec2f(23.140779495239258, 232.6168975830078));
let b = dot(seed_1, vec2f(54.47856521606445, 345.8415222167969));
seed_1.x = fract((cos(a) * 136.8168f));
seed_1.y = fract((cos(b) * 534.7645f));
return seed_1.y;
}

fn randOnUnitSphere() -> vec3f {
Expand Down
14 changes: 7 additions & 7 deletions apps/typegpu-docs/tests/individual-example-tests/clouds.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,11 @@ describe('clouds example', () => {
return ((x << k) | (x >> (32u - k)));
}

var<private> seed: vec2f;
var<private> seed_1: vec2f;

fn seed2(value: vec2f) {
let scrambled = scrambleSeed2(value);
seed = ((vec2f(u32To01F32(hash((scrambled.x ^ scrambled.y))), u32To01F32(hash((rotl(scrambled.x, 16u) ^ scrambled.y)))) * 2f) - 1f);
seed_1 = ((vec2f(u32To01F32(hash((scrambled.x ^ scrambled.y))), u32To01F32(hash((rotl(scrambled.x, 16u) ^ scrambled.y)))) * 2f) - 1f);
}

fn randSeed2(seed: vec2f) {
Expand All @@ -85,11 +85,11 @@ describe('clouds example', () => {
@group(0) @binding(0) var<uniform> resolutionUniform: vec2f;

fn sample() -> f32 {
let a = dot(seed, vec2f(23.140779495239258, 232.6168975830078));
let b = dot(seed, vec2f(54.47856521606445, 345.8415222167969));
seed.x = fract((cos(a) * 136.8168f));
seed.y = fract((cos(b) * 534.7645f));
return seed.y;
let a = dot(seed_1, vec2f(23.140779495239258, 232.6168975830078));
let b = dot(seed_1, vec2f(54.47856521606445, 345.8415222167969));
seed_1.x = fract((cos(a) * 136.8168f));
seed_1.y = fract((cos(b) * 534.7645f));
return seed_1.y;
}

fn randFloat01() -> f32 {
Expand Down
28 changes: 14 additions & 14 deletions apps/typegpu-docs/tests/individual-example-tests/fluid-double-buffering.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,11 +130,11 @@ describe('fluid double buffering example', () => {
return ((x << k) | (x >> (32u - k)));
}

var<private> seed: vec2f;
var<private> seed_1: vec2f;

fn seed2(value: vec2f) {
let scrambled = scrambleSeed2(value);
seed = ((vec2f(u32To01F32(hash((scrambled.x ^ scrambled.y))), u32To01F32(hash((rotl(scrambled.x, 16u) ^ scrambled.y)))) * 2f) - 1f);
seed_1 = ((vec2f(u32To01F32(hash((scrambled.x ^ scrambled.y))), u32To01F32(hash((rotl(scrambled.x, 16u) ^ scrambled.y)))) * 2f) - 1f);
}

fn randSeed2(seed: vec2f) {
Expand Down Expand Up @@ -189,11 +189,11 @@ describe('fluid double buffering example', () => {
}

fn sample() -> f32 {
let a = dot(seed, vec2f(23.140779495239258, 232.6168975830078));
let b = dot(seed, vec2f(54.47856521606445, 345.8415222167969));
seed.x = fract((cos(a) * 136.8168f));
seed.y = fract((cos(b) * 534.7645f));
return seed.y;
let a = dot(seed_1, vec2f(23.140779495239258, 232.6168975830078));
let b = dot(seed_1, vec2f(54.47856521606445, 345.8415222167969));
seed_1.x = fract((cos(a) * 136.8168f));
seed_1.y = fract((cos(b) * 534.7645f));
return seed_1.y;
}

fn randFloat01() -> f32 {
Expand Down Expand Up @@ -387,11 +387,11 @@ describe('fluid double buffering example', () => {
return ((x << k) | (x >> (32u - k)));
}

var<private> seed: vec2f;
var<private> seed_1: vec2f;

fn seed2(value: vec2f) {
let scrambled = scrambleSeed2(value);
seed = ((vec2f(u32To01F32(hash((scrambled.x ^ scrambled.y))), u32To01F32(hash((rotl(scrambled.x, 16u) ^ scrambled.y)))) * 2f) - 1f);
seed_1 = ((vec2f(u32To01F32(hash((scrambled.x ^ scrambled.y))), u32To01F32(hash((rotl(scrambled.x, 16u) ^ scrambled.y)))) * 2f) - 1f);
}

fn randSeed2(seed: vec2f) {
Expand Down Expand Up @@ -446,11 +446,11 @@ describe('fluid double buffering example', () => {
}

fn sample() -> f32 {
let a = dot(seed, vec2f(23.140779495239258, 232.6168975830078));
let b = dot(seed, vec2f(54.47856521606445, 345.8415222167969));
seed.x = fract((cos(a) * 136.8168f));
seed.y = fract((cos(b) * 534.7645f));
return seed.y;
let a = dot(seed_1, vec2f(23.140779495239258, 232.6168975830078));
let b = dot(seed_1, vec2f(54.47856521606445, 345.8415222167969));
seed_1.x = fract((cos(a) * 136.8168f));
seed_1.y = fract((cos(b) * 534.7645f));
return seed_1.y;
}

fn randFloat01() -> f32 {
Expand Down
14 changes: 7 additions & 7 deletions apps/typegpu-docs/tests/individual-example-tests/game-of-life.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,23 +56,23 @@ describe('game of life example', () => {
return ((x << k) | (x >> (32u - k)));
}

var<private> seed: vec2f;
var<private> seed_1: vec2f;

fn seed2(value: vec2f) {
let scrambled = scrambleSeed2(value);
seed = ((vec2f(u32To01F32(hash((scrambled.x ^ scrambled.y))), u32To01F32(hash((rotl(scrambled.x, 16u) ^ scrambled.y)))) * 2f) - 1f);
seed_1 = ((vec2f(u32To01F32(hash((scrambled.x ^ scrambled.y))), u32To01F32(hash((rotl(scrambled.x, 16u) ^ scrambled.y)))) * 2f) - 1f);
}

fn randSeed2(seed: vec2f) {
seed2(seed);
}

fn sample() -> f32 {
let a = dot(seed, vec2f(23.140779495239258, 232.6168975830078));
let b = dot(seed, vec2f(54.47856521606445, 345.8415222167969));
seed.x = fract((cos(a) * 136.8168f));
seed.y = fract((cos(b) * 534.7645f));
return seed.y;
let a = dot(seed_1, vec2f(23.140779495239258, 232.6168975830078));
let b = dot(seed_1, vec2f(54.47856521606445, 345.8415222167969));
seed_1.x = fract((cos(a) * 136.8168f));
seed_1.y = fract((cos(b) * 534.7645f));
return seed_1.y;
}

fn randFloat01() -> f32 {
Expand Down
14 changes: 7 additions & 7 deletions apps/typegpu-docs/tests/individual-example-tests/jelly-slider.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,11 @@ describe('jelly-slider example', () => {
return ((x << k) | (x >> (32u - k)));
}

var<private> seed: vec2f;
var<private> seed_1: vec2f;

fn seed2(value: vec2f) {
let scrambled = scrambleSeed2(value);
seed = ((vec2f(u32To01F32(hash((scrambled.x ^ scrambled.y))), u32To01F32(hash((rotl(scrambled.x, 16u) ^ scrambled.y)))) * 2f) - 1f);
seed_1 = ((vec2f(u32To01F32(hash((scrambled.x ^ scrambled.y))), u32To01F32(hash((rotl(scrambled.x, 16u) ^ scrambled.y)))) * 2f) - 1f);
}

fn randSeed2(seed: vec2f) {
Expand Down Expand Up @@ -200,11 +200,11 @@ describe('jelly-slider example', () => {
@group(1) @binding(1) var bezierTexture: texture_2d<f32>;

fn sample() -> f32 {
let a = dot(seed, vec2f(23.140779495239258, 232.6168975830078));
let b = dot(seed, vec2f(54.47856521606445, 345.8415222167969));
seed.x = fract((cos(a) * 136.8168f));
seed.y = fract((cos(b) * 534.7645f));
return seed.y;
let a = dot(seed_1, vec2f(23.140779495239258, 232.6168975830078));
let b = dot(seed_1, vec2f(54.47856521606445, 345.8415222167969));
seed_1.x = fract((cos(a) * 136.8168f));
seed_1.y = fract((cos(b) * 534.7645f));
return seed_1.y;
}

fn randFloat01() -> f32 {
Expand Down
4 changes: 2 additions & 2 deletions apps/typegpu-docs/tests/individual-example-tests/jelly-switch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,11 @@ describe('jelly switch example', () => {
return ((x << k) | (x >> (32u - k)));
}
var<private> seed: vec2f;
var<private> seed_1: vec2f;
fn seed2(value: vec2f) {
let scrambled = scrambleSeed2(value);
seed = ((vec2f(u32To01F32(hash((scrambled.x ^ scrambled.y))), u32To01F32(hash((rotl(scrambled.x, 16u) ^ scrambled.y)))) * 2f) - 1f);
seed_1 = ((vec2f(u32To01F32(hash((scrambled.x ^ scrambled.y))), u32To01F32(hash((rotl(scrambled.x, 16u) ^ scrambled.y)))) * 2f) - 1f);
}
fn randSeed2(seed: vec2f) {
Expand Down
14 changes: 7 additions & 7 deletions apps/typegpu-docs/tests/individual-example-tests/jump-flood-voronoi.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,23 +57,23 @@ describe('jump flood (voronoi) example', () => {
return ((x << k) | (x >> (32u - k)));
}

var<private> seed: vec2f;
var<private> seed_1: vec2f;

fn seed2(value: vec2f) {
let scrambled = scrambleSeed2(value);
seed = ((vec2f(u32To01F32(hash((scrambled.x ^ scrambled.y))), u32To01F32(hash((rotl(scrambled.x, 16u) ^ scrambled.y)))) * 2f) - 1f);
seed_1 = ((vec2f(u32To01F32(hash((scrambled.x ^ scrambled.y))), u32To01F32(hash((rotl(scrambled.x, 16u) ^ scrambled.y)))) * 2f) - 1f);
}

fn randSeed2(seed: vec2f) {
seed2(seed);
}

fn sample() -> f32 {
let a = dot(seed, vec2f(23.140779495239258, 232.6168975830078));
let b = dot(seed, vec2f(54.47856521606445, 345.8415222167969));
seed.x = fract((cos(a) * 136.8168f));
seed.y = fract((cos(b) * 534.7645f));
return seed.y;
let a = dot(seed_1, vec2f(23.140779495239258, 232.6168975830078));
let b = dot(seed_1, vec2f(54.47856521606445, 345.8415222167969));
seed_1.x = fract((cos(a) * 136.8168f));
seed_1.y = fract((cos(b) * 534.7645f));
return seed_1.y;
}

fn randFloat01() -> f32 {
Expand Down
14 changes: 7 additions & 7 deletions apps/typegpu-docs/tests/individual-example-tests/perlin-noise.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,23 +55,23 @@ describe('perlin noise example', () => {
return (f - 1f);
}

var<private> seed: vec2f;
var<private> seed_1: vec2f;

fn seed3(value: vec3f) {
let scrambled = scrambleSeed3(value);
seed = ((vec2f(u32To01F32(hash((scrambled.x ^ rotl(scrambled.z, 16u)))), u32To01F32(hash((rotl(scrambled.y, 16u) ^ scrambled.z)))) * 2f) - 1f);
seed_1 = ((vec2f(u32To01F32(hash((scrambled.x ^ rotl(scrambled.z, 16u)))), u32To01F32(hash((rotl(scrambled.y, 16u) ^ scrambled.z)))) * 2f) - 1f);
}

fn randSeed3(seed: vec3f) {
seed3(seed);
}

fn sample() -> f32 {
let a = dot(seed, vec2f(23.140779495239258, 232.6168975830078));
let b = dot(seed, vec2f(54.47856521606445, 345.8415222167969));
seed.x = fract((cos(a) * 136.8168f));
seed.y = fract((cos(b) * 534.7645f));
return seed.y;
let a = dot(seed_1, vec2f(23.140779495239258, 232.6168975830078));
let b = dot(seed_1, vec2f(54.47856521606445, 345.8415222167969));
seed_1.x = fract((cos(a) * 136.8168f));
seed_1.y = fract((cos(b) * 534.7645f));
return seed_1.y;
}

fn randOnUnitSphere() -> vec3f {
Expand Down
Loading
Loading