-
-
Notifications
You must be signed in to change notification settings - Fork 76
feat: Introduce Tgpu(RenderPass/ComputePass/CommandEncoder) and remove the old callback based APIs
#2764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
feat: Introduce Tgpu(RenderPass/ComputePass/CommandEncoder) and remove the old callback based APIs
#2764
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e202cc0
typed command encoder and passes
reczkok 03b1481
trim encoder scaffolding
reczkok 77b3010
fixes
reczkok c576c81
test fixes
reczkok 1d79069
warn about pipeline attachments dropped by a shared pass
reczkok 5f46f0e
passes hold all draw state, with pipelines stamping their bindings in…
reczkok bff6446
polish and bug prevention
reczkok b7eae67
kill remnants of the old api: beginRenderBundleEncoder -> createRende…
reczkok 378af3a
review fixes and logger integration
reczkok 3f1f2d1
review fixes + add encoders to clear/copy (trivial and it bugged me v…
reczkok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we add a note in docs that the API mixing may be unintuitive? const encoder = root['~unstable'].createCommandEncoder();
const pass = encoder.beginComputePass();
pass.setPipeline(pipelineA);
pipelineB.with(pass).dispatchWorkgroups(1);
pass.dispatchWorkgroups(1);
pass.end();
encoder.submit(); // "B" is printed twice
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added a note, take a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd make passes and encoders namable:
stacked PR❓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will open an issue, not a priority for me now