Skip to content

Implicit relative #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MWR27 wants to merge 2 commits into
base: migration
Choose a base branch
from
Open

Implicit relative #50

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82d1fad
Add warning for implicit relative imports
MWR27 Jun 3, 2026
411eee5
Fix not recognizing submodules in multiple levels of subpackages
MWR27 Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions Python/import.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2247,6 +2247,11 @@ import_module_level(char *name, PyObject *globals, PyObject *locals,
Py_ssize_t buflen = 0;
PyObject *parent, *head, *next, *tail;

char parentstr[MAXPATHLEN + 1]; /* maybe rename to pkgstr or pkgname? */
char *orig_name = name;
int is_from_form;
int might_warn_implicit;

if (strchr(name, '/') != NULL
#ifdef MS_WINDOWS
|| strchr(name, '\\') != NULL
Expand All @@ -2265,6 +2270,14 @@ import_module_level(char *name, PyObject *globals, PyObject *locals,
if (parent == NULL)
goto error_exit;

might_warn_implicit = level < 0 &&
parent != Py_None &&
strchr(name, '.') == NULL &&
buflen + strlen(name) + 1 <= MAXPATHLEN;
if (might_warn_implicit) {
memcpy(parentstr, buf, buflen + 1);
}

Py_INCREF(parent);
head = load_next(parent, level < 0 ? Py_None : parent, &name, buf,
&buflen);
Expand Down Expand Up @@ -2303,6 +2316,35 @@ import_module_level(char *name, PyObject *globals, PyObject *locals,
}
if (!b)
fromlist = NULL;
is_from_form = b;
}

if (might_warn_implicit) {
char potential_resolved[MAXPATHLEN + 2];
sprintf(potential_resolved, "%s.%s", parentstr, orig_name);

if (strcmp(potential_resolved, buf) == 0) {
char msg[524];
char fix[260];
if (is_from_form) {
sprintf(msg,
"implicit relative import from '%.200s' resolved to '%.200s'; "
"in 3.x imports are absolute by default, so this may resolve differently",
orig_name, buf);
sprintf(fix,
"use 'from %.200s import ...' if the parent package is intended", buf);
} else {
sprintf(msg,
"implicit relative import '%.200s' resolved to '%.200s'; "
"in 3.x imports are absolute by default, so this may resolve differently",
orig_name, buf);
sprintf(fix,
"use 'import %.200s' if the parent package is intended", buf);
}
if (PyErr_WarnPy3k_WithFix(msg, fix, 1) < 0) {
goto error_exit;
}
}
}

if (fromlist == NULL) {
Expand Down