settings: add biometric preference flow #716
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| package com.softartdev.notedelight.interactor | ||
|
|
||
| import android.app.KeyguardManager | ||
| import android.content.Context | ||
| import android.hardware.fingerprint.FingerprintManager | ||
| import android.os.Build | ||
|
|
||
| actual class BiometricInteractor(private val context: Context) { | ||
| private val prefs = context.getSharedPreferences(PREFS_NAME, Context.MODE_PRIVATE) | ||
|
|
||
| actual var biometricEnabled: Boolean | ||
| get() = prefs.getBoolean(KEY_BIOMETRIC_ENABLED, false) | ||
| set(value) { | ||
| prefs.edit().putBoolean(KEY_BIOMETRIC_ENABLED, value).apply() | ||
| } | ||
|
|
||
| actual var biometricConfirmed: Boolean | ||
| get() = prefs.getBoolean(KEY_BIOMETRIC_CONFIRMED, false) | ||
| set(value) { | ||
| prefs.edit().putBoolean(KEY_BIOMETRIC_CONFIRMED, value).apply() | ||
| } | ||
|
|
||
| actual fun capability(): BiometricCapability { | ||
| if (Build.VERSION.SDK_INT < Build.VERSION_CODES.M) { | ||
| return BiometricCapability(available = false, enrolled = false) | ||
| } | ||
| val fingerprintManager = context.getSystemService(Context.FINGERPRINT_SERVICE) as? FingerprintManager | ||
| ?: return BiometricCapability(available = false, enrolled = false) | ||
| val keyguardManager = context.getSystemService(Context.KEYGUARD_SERVICE) as? KeyguardManager | ||
| val available = fingerprintManager.isHardwareDetected && (keyguardManager?.isKeyguardSecure == true) | ||
| val enrolled = available && fingerprintManager.hasEnrolledFingerprints() | ||
|
Comment on lines
+27
to
+31
There was a problem hiding this comment.
This implementation treats biometrics as available only when a fingerprint sensor is present, which incorrectly disables the new “Enable biometrics” setting on devices that support non-fingerprint biometrics (for example, face/iris-only hardware). Since the feature is exposed as generic biometrics, capability should be checked via Useful? React with 👍 / 👎. |
||
| return BiometricCapability(available = available, enrolled = enrolled) | ||
| } | ||
|
|
||
| private companion object { | ||
| private const val PREFS_NAME = "notedelight_settings" | ||
| private const val KEY_BIOMETRIC_ENABLED = "biometric_enabled" | ||
| private const val KEY_BIOMETRIC_CONFIRMED = "biometric_confirmed" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| package com.softartdev.notedelight.interactor | ||
|
|
||
| data class BiometricCapability( | ||
| val available: Boolean, | ||
| val enrolled: Boolean, | ||
| ) | ||
|
|
||
| expect class BiometricInteractor { | ||
| var biometricEnabled: Boolean | ||
| var biometricConfirmed: Boolean | ||
| fun capability(): BiometricCapability | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| package com.softartdev.notedelight.interactor | ||
|
|
||
| import platform.Foundation.NSUserDefaults | ||
|
|
||
| actual class BiometricInteractor { | ||
| actual var biometricEnabled: Boolean | ||
| get() = NSUserDefaults.standardUserDefaults.boolForKey(KEY_BIOMETRIC_ENABLED) | ||
| set(value) { | ||
| NSUserDefaults.standardUserDefaults.setBool(value, KEY_BIOMETRIC_ENABLED) | ||
| } | ||
|
|
||
| actual var biometricConfirmed: Boolean | ||
| get() = NSUserDefaults.standardUserDefaults.boolForKey(KEY_BIOMETRIC_CONFIRMED) | ||
| set(value) { | ||
| NSUserDefaults.standardUserDefaults.setBool(value, KEY_BIOMETRIC_CONFIRMED) | ||
| } | ||
|
|
||
| actual fun capability(): BiometricCapability = BiometricCapability( | ||
| available = false, | ||
| enrolled = false, | ||
| ) | ||
|
|
||
| private companion object { | ||
| private const val KEY_BIOMETRIC_ENABLED = "biometric_enabled" | ||
| private const val KEY_BIOMETRIC_CONFIRMED = "biometric_confirmed" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| package com.softartdev.notedelight.interactor | ||
|
|
||
| import java.util.prefs.Preferences | ||
|
|
||
| actual class BiometricInteractor { | ||
| private val preferences = Preferences.userRoot().node(PREFS_NODE) | ||
|
|
||
| actual var biometricEnabled: Boolean | ||
| get() = preferences.getBoolean(KEY_BIOMETRIC_ENABLED, false) | ||
| set(value) { | ||
| preferences.putBoolean(KEY_BIOMETRIC_ENABLED, value) | ||
| } | ||
|
|
||
| actual var biometricConfirmed: Boolean | ||
| get() = preferences.getBoolean(KEY_BIOMETRIC_CONFIRMED, false) | ||
| set(value) { | ||
| preferences.putBoolean(KEY_BIOMETRIC_CONFIRMED, value) | ||
| } | ||
|
|
||
| actual fun capability(): BiometricCapability = BiometricCapability( | ||
| available = false, | ||
| enrolled = false, | ||
| ) | ||
|
|
||
| private companion object { | ||
| private const val PREFS_NODE = "com.softartdev.notedelight.settings" | ||
| private const val KEY_BIOMETRIC_ENABLED = "biometric_enabled" | ||
| private const val KEY_BIOMETRIC_CONFIRMED = "biometric_confirmed" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| package com.softartdev.notedelight.interactor | ||
|
|
||
| import kotlinx.browser.window | ||
|
|
||
| actual class BiometricInteractor { | ||
| actual var biometricEnabled: Boolean | ||
| get() = localStorageItem(KEY_BIOMETRIC_ENABLED) == TRUE_VALUE | ||
| set(value) { | ||
| setLocalStorageItem(KEY_BIOMETRIC_ENABLED, value.toString()) | ||
| } | ||
|
|
||
| actual var biometricConfirmed: Boolean | ||
| get() = localStorageItem(KEY_BIOMETRIC_CONFIRMED) == TRUE_VALUE | ||
| set(value) { | ||
| setLocalStorageItem(KEY_BIOMETRIC_CONFIRMED, value.toString()) | ||
| } | ||
|
|
||
| actual fun capability(): BiometricCapability = BiometricCapability( | ||
| available = false, | ||
| enrolled = false, | ||
| ) | ||
|
|
||
| private companion object { | ||
| private const val KEY_BIOMETRIC_ENABLED = "biometric_enabled" | ||
| private const val KEY_BIOMETRIC_CONFIRMED = "biometric_confirmed" | ||
| private const val TRUE_VALUE = "true" | ||
| } | ||
| } | ||
|
|
||
| private fun localStorageItem(key: String): String? = window.localStorage.getItem(key) | ||
|
|
||
| private fun setLocalStorageItem(key: String, value: String) = window.localStorage.setItem(key, value) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
capability()callsFingerprintManager.isHardwareDetected()andhasEnrolledFingerprints()without any declared biometric/fingerprint permission in the Android manifests, so this path can raiseSecurityExceptionat runtime when settings refreshes (it runs fromupdateSwitches()on resume). Please declareUSE_BIOMETRIC/USE_FINGERPRINTin the app manifest (or use an API path that avoids this requirement) before invoking these methods.Useful? React with 👍 / 👎.