fix: remove deprecated Task.yield call#24
Closed
seuros wants to merge 1 commit into
Closed
Conversation
Task.yield is deprecated with no replacement. The call was redundant since self.wait already blocks and yields to other fibers through the condition variable. Simplified the gardener loop to just call the policy (if present) and wait for resource releases.
Member
|
This PR was a bit hard to merge, so I did it by hand and released in v0.11.1. Thanks for your efforts and bringing this to my attention. |
Author
|
Sorry, i did not see the trailing space removal, i use the dictator on watch mode. So it just auto fixed them. |
Member
|
It's all good. Thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Task.yieldis deprecated with no replacement (warning appears in Ruby 3.4+).The call was redundant since
self.waitalready blocks and yields to other fibers through the condition variable.Changes
Simplified the gardener loop from:
To:
Test plan