Support passing Async::Semaphore as the parent task for Async::Job::Processor::Redis::Server - #5
Open
shaokun wants to merge 1 commit into
Open
Conversation
…rocessor::Redis::Server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
Async::Job::Processor::Redis::Serverto support passing anAsync::Semaphoreas the parent task. The change restructures the concurrency model by moving job processing into a separate async task wrapper, allowing for better control over concurrent job execution through semaphores.Key Changes:
dequeuemethod: Removed theparentparameter fromdequeue- job processing logic is now synchronous within its async wrapperThis change maintains backward compatibility while enabling use cases where you want to limit the number of jobs processed concurrently (e.g., rate limiting, resource management).
Types of Changes
Contribution