Skip to content

fix(ci): close review-flagged gaps in dependabot-auto-merge.yml - #47

Merged
smartwatermelon merged 4 commits into
mainfrom
claude/chore-fix-review-findings-1785812487
Aug 4, 2026
Merged

fix(ci): close review-flagged gaps in dependabot-auto-merge.yml#47
smartwatermelon merged 4 commits into
mainfrom
claude/chore-fix-review-findings-1785812487

Conversation

@smartwatermelon

Copy link
Copy Markdown
Owner

Summary

Fixes the four auto-filed non-blocking review findings from PR #39's fleet remediation work, applied directly to this repo's dependabot-auto-merge.yml and scripts/drop-noop-approve-step.sh:

Also, while fixing this file directly:

Two more non-blocking findings (#45, #46) were auto-filed during this branch's own push reviews. Left open for a follow-up pass rather than chased further here — diminishing returns on a docs/tooling-only branch.

Test plan

  • bash -n syntax check on both shell scripts
  • zizmor clean on dependabot-auto-merge.yml (was 3 findings, now 0)
  • Local pre-commit review (code-reviewer + adversarial-reviewer) passed on every commit
  • Local pre-push full-diff + codebase review passed on every push

Closes #41, #40, #38, #37, #42, #43, #44.

https://claude.ai/code/session_01SsnvQEpWgMxcRocq8bBVSE

Claude Code Bot added 4 commits August 3, 2026 20:03
…rop script

- Fail closed when dependency-names parses to nothing but a
  non-empty string (e.g. all-whitespace/comma input), instead of
  treating it as an implicitly trusted empty remainder (#41).
- Switch the job's bot-actor gate to
  github.event.pull_request.user.login, since github.actor is
  spoofable on pull_request_target (last committer, not PR author);
  document the resulting synchronize-trigger tradeoff instead of
  hiding it (#40).
- Drop the now-fully-inert `gh pr review --approve` step: no repo in
  the fleet requires an approving review, confirmed by the dev-env#21
  audit.
- SHA-pin dependabot/fetch-metadata and suppress the intentional
  pull_request_target trigger finding, both caught by zizmor's
  pre-commit hook while preparing this change.
- Reset clone-err.log per repo instead of leaving stale content from
  a prior repo's failed clone (#38).
- Hoist commit-msg/PR-body template writes out of the per-repo loop
  in drop-noop-approve-step.sh; they never varied by iteration (#37).
- Add retry-noop-approve-zizmor-fixes.sh, the follow-up script for
  the 20 fleet repos whose drop-noop-approve-step.sh run hit the same
  zizmor findings fixed here directly; dev-env is excluded from its
  repo list since this commit fixes it in place.

Closes #41, #40, #38, #37.

Claude-Session: https://claude.ai/code/session_01SsnvQEpWgMxcRocq8bBVSE
…xes.sh

Matches the #38 fix already applied to drop-noop-approve-step.sh;
adversarial reviewer flagged the inconsistency on the prior commit.

Claude-Session: https://claude.ai/code/session_01SsnvQEpWgMxcRocq8bBVSE
- The comment claiming no pre-commit hook runs in scratch clones was
  wrong: core.hooksPath is machine-global, so it does fire (that's
  what caused the 20-repo zizmor failures this run's retry script
  exists to fix). Correct the comment to match reality.
- The PR body claimed removing the approve step also removes
  pull-requests: write usage, but gh pr merge --auto requires that
  permission independently. Correct the claim.

Closes #42, #43.

Claude-Session: https://claude.ai/code/session_01SsnvQEpWgMxcRocq8bBVSE
Every other failure path in this script echoes the captured detail
inline; the gh pr create path silently dropped it, only writing it
to the TSV log.

Closes #44.

Claude-Session: https://claude.ai/code/session_01SsnvQEpWgMxcRocq8bBVSE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant