docs: formalize .semgrepignore convention for pre-existing findings - #33
Merged
Merged
Conversation
semgrep scan --staged doesn't exist, so the pre-commit hook scans the whole tracked repo and can be blocked by pre-existing findings on unrelated files. Document the per-repo .semgrepignore workaround (narrow scope, justified inline) validated in smartwatermelon/tensegrity, so future repos don't have to rediscover it via issue #1's comment thread. Claude-Session: https://claude.ai/code/session_01SsnvQEpWgMxcRocq8bBVSE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.semgrepignoreconvention (per-repo, narrowly-scoped, justified inline) as the recommended fix for pre-existing Semgrep findings blocking unrelated commits, sincesemgrep scan --stageddoesn't exist and the pre-commit hook scans the whole tracked repo.docs/local-code-review-options.md, referencing the validated 2026-04-09 usage insmartwatermelon/tensegrityand explaining why it's preferred over filteringsemgrep scanto staged-file targets..semgrepignoresnippet.Closes #1
Test plan
https://claude.ai/code/session_01SsnvQEpWgMxcRocq8bBVSE