usr: clear the attach manifest on do_clean so clean+build is reliable#266
Merged
Conversation
Generic meta-usr fix. The usr build mutates the attached tree (IB_TARGET)
in place — e.g. the :lvgl override fetches lib/lvgl and renames its stray
CMakeLists.txt (-> __CMakeLists.txt__) to hide them from the recursive CMake
glob. Those renames/removals make the next do_attach_infrabase abort:
'sha256sum -c ${IB_TARGET}.attach.sha256' reports the manifest's original
entries as FAILED (renamed/missing) -> 'Refusing to re-attach usr-so3'.
Clear the manifest in usr.bbclass:do_clean (applies to every usr recipe:
usr-so3, usr-linux) so the next attach re-attaches from a fresh fetch+patch
instead of checking stale entries. A clean is an explicit reset and the attach
still backs the tree up to ${IB_TARGET}.back; the guard stays fully active for
builds NOT preceded by a clean.
Validated: 'build.sh -xc bsp-so3' (clean+build, :lvgl) now succeeds repeatedly
(was failing on the 2nd run).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the recurring
Refusing to re-attach usr-so3failure onbuild.sh -xc bsp-so3(and any usr recipe) when a build mutates the attached tree in place — notably the:lvgloverride, which fetcheslib/lvgland renames its strayCMakeLists.txtto hide them from the recursive CMake glob. Those renames makedo_attach_infrabase'ssha256sum -creport the manifest entries as FAILED on the next attach.Generic fix in
meta-usr/classes/usr.bbclass:do_clean(not per-recipe): drop${IB_TARGET}.attach.sha256on clean so the next attach re-attaches fresh. Safe — a clean is an explicit reset, the attach still keeps${IB_TARGET}.back, and the guard stays active for builds not preceded by a clean.Validated:
build.sh -xc bsp-so3with:lvglnow succeeds on two consecutive runs (previously failed on the 2nd).