DS-4027: Reconnection Counter Underflow Fix - #73
Open
andrejrakic wants to merge 1 commit into
Open
andrejrakic wants to merge 1 commit into
andrejrakic wants to merge 1 commit into
Conversation
andrejrakic
marked this pull request as ready for review
September 11, 2026 11:21
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the Reconnection Counter Underflow issue and adds another unit test to confirm the fix.
What was the issue
Per WebSocket RFC 6455, after a Close frame the stream always yields
None— theNonearm is the definitive end-of-stream signal. TheMessage::Closearm should not decrement; removing that call makes each graceful close/reconnect cycle net-zero. Without the fix, repeated cycles underflow theAtomicUsizecounter tousize::MAX, causing full reconnects to be misclassified as partial.