Simulate Solana LogTrigger#534
Open
silaslenihan wants to merge 18 commits into
Open
Conversation
silaslenihan
force-pushed
the
feat/simulate-solana-logtrigger
branch
from
July 16, 2026 19:16
8887bab to
b19e772
Compare
silaslenihan
force-pushed
the
feat/simulate-solana-logtrigger
branch
from
July 16, 2026 19:36
141ab35 to
3fc2304
Compare
silaslenihan
marked this pull request as ready for review
July 16, 2026 19:43
silaslenihan
marked this pull request as draft
July 16, 2026 19:51
silaslenihan
force-pushed
the
feat/simulate-solana-logtrigger
branch
from
July 16, 2026 20:38
5dc08a9 to
7e087ce
Compare
silaslenihan
marked this pull request as ready for review
July 16, 2026 20:55
yashnevatia
previously approved these changes
Jul 20, 2026
| return nil, fmt.Errorf("--%s and --%s are required for Solana log triggers", TriggerInputTxSig, TriggerInputEventIndex) | ||
| } | ||
| if eventIndexStr == "" { | ||
| return nil, fmt.Errorf("--%s is required when --%s is provided", TriggerInputEventIndex, TriggerInputTxSig) |
Contributor
There was a problem hiding this comment.
error is misleading. It gives the impression that eventIndexStr is optional.
Making it required does not seem to align with EVM implementation, where the user can specify an event index or a filter. Am I missing something?
Collaborator
Author
There was a problem hiding this comment.
EVM supports live listening when a tx sig isn't supplied but I decided to leave that out for Solana for now in favor of replay-only which requires the txsig. In the replay path in EVM, index is required as well. I updated the error and comment to be a little more accurate.
silaslenihan
force-pushed
the
feat/simulate-solana-logtrigger
branch
from
July 22, 2026 14:08
c475d7a to
574f882
Compare
Unheilbar
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually tested with local built binary and sollogtrigger workflow.
Program event:
CPI Event