cre-4799: Shard Failover - sender and receiver wired - #23487
Open
mchain0 wants to merge 2 commits into
Open
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
|
I see you updated files related to
|
mchain0
force-pushed
the
cre-4799-p2
branch
4 times, most recently
from
August 21, 2026 15:32
98427a4 to
d77a574
Compare
mchain0
marked this pull request as ready for review
August 21, 2026 16:14
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sender and receiver are fully wired:
wireShardFailoverHookscreates anExecutionCompletedSender(targeting the secondary DON resolved viashardDonLookup), wires it into the engine'sOnExecutionCompletedlifecycle hook, and registers it as a sub-service for lifecycle management.wireShardFailoverHookscreates anExecutionCompletedReceiverand registers it with the dispatcher viaSetReceiverForMethod(MethodExecutionCompleted)so incoming Don2Don messages are delivered to it.isPrimaryShardForDonusesAllShardsResolver.ResolveAllShardsto determine if this shard is the primary (first in the assignment list).newShardDonLookupusesCapabilitiesRegistry.DONByIDto resolve peer membership for the other shard.cre.go->newWorkflowRegistrySyncer->newWorkflowRegistrySyncerV2-> handler options.It is supplementary to #23457