Skip to content

Trivial Fixes after Auto-Fixes - #23465

Open
kalverra wants to merge 2 commits into
DX-5066/main-module-auto-fixfrom
DX-5066/main-module-deeper-fix
Open

Trivial Fixes after Auto-Fixes#23465
kalverra wants to merge 2 commits into
DX-5066/main-module-auto-fixfrom
DX-5066/main-module-deeper-fix

Conversation

@kalverra

Copy link
Copy Markdown
Collaborator

Stack created with GitHub Stacks CLIGive Feedback 💬

@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

CORA - Pending Reviewers

Codeowners Entry Overall Num Files Owners
* 💬 221 @smartcontractkit/foundations, @smartcontractkit/core
/core/services/feeds/ 💬 3 @smartcontractkit/core, @smartcontractkit/devex-tooling
/core/capabilities/ 💬 16 @smartcontractkit/keystone, @smartcontractkit/capabilities-team
/core/capabilities/ccip/ 36 @smartcontractkit/ccip-offchain
/core/capabilities/ccip/ccipsolana/ 8 @smartcontractkit/bix-build
/core/capabilities/ccip/ccipnoop/ 4 @smartcontractkit/bix-build
/core/capabilities/confidentialrelay/ 1 @smartcontractkit/privacy
/core/services/job/ 💬 9 @smartcontractkit/foundations, @smartcontractkit/core
/core/services/keystore/ 💬 12 @smartcontractkit/foundations
/core/services/ocr*/ 💬 14 @smartcontractkit/foundations, @smartcontractkit/core
/core/services/periodicbackup/ 💬 2 @smartcontractkit/foundations, @smartcontractkit/core
/core/services/pg/ 💬 4 @smartcontractkit/foundations, @smartcontractkit/core
/core/services/pipeline/ 💬 26 @smartcontractkit/foundations, @smartcontractkit/bix-framework, @smartcontractkit/core
/core/services/telemetry/ 💬 1 @smartcontractkit/data-tooling, @smartcontractkit/core
/core/services/llo/ 💬 5 @smartcontractkit/data-streams-engineers, @smartcontractkit/core
/core/services/vrf/ 💬 8 @smartcontractkit/dev-services, @smartcontractkit/core
/core/services/blockhashstore/ 💬 3 @smartcontractkit/dev-services, @smartcontractkit/core
/core/services/blockheaderfeeder/ 💬 2 @smartcontractkit/dev-services, @smartcontractkit/core
/core/services/pipeline/task.vrfv2.go 1 @smartcontractkit/dev-services
/core/services/pipeline/task.vrfv2plus.go 1 @smartcontractkit/dev-services
/core/scripts/vrf*/ 8 @smartcontractkit/dev-services
/core/services/ocr2/plugins/ocr2keeper/ 9 @smartcontractkit/dev-services
/core/services/registrysyncer/ 💬 6 @smartcontractkit/keystone
/core/services/workflows/ 💬 7 @smartcontractkit/keystone
/core/services/standardcapabilities/ 💬 1 @smartcontractkit/keystone
/core/services/gateway/handlers/confidentialrelay/ 2 @smartcontractkit/privacy
/core/web/resolver/ 💬 1 @smartcontractkit/foundations, @smartcontractkit/core
/deployment/ 💬 1 @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/operations-platform, @smartcontractkit/core

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@github-actions

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@cl-sonarqube-production

Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
7 New Major Issues (required ≤ 5)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE SonarQube for IDE

@github-actions

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting DX-5066/main-module-auto-fix

@@ -22,6 +22,7 @@ func TestOCRKeysController_Index_HappyPath(t *testing.T) {
keys, _ := OCRKeyStore.GetAll()

response, cleanup := client.Get("/v2/keys/ocr")
defer response.Body.Close()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cleanup func already closes the body

@trunk-io

trunk-io Bot commented Aug 19, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Test_CRE_V2_Suite_Bucket_B/Vault_DON_-_mixed-env The test failed because it could not obtain the required quorum of responses when fetching the Vault Public Key. Logs ↗︎
Test_CRE_V2_Suite_Bucket_B The test named Test_CRE_V2_Suite_Bucket_B failed to run successfully. Logs ↗︎
Test_CCIP_ReceiverNotRegistered_EVM2Sui The test failed without a specific error message, but it appears to be related to the 'Test_CCIP_ReceiverNotRegistered_EVM2Sui' test case, possi... Logs ↗︎
FuzzParse/seed#13 A goroutine logged an error after the test had already completed, caused by a failed connection attempt due to disabled stream dialing. Logs ↗︎

... and 5 more

View Full Report ↗︎Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants