[CRE-6174] Engine Execution Endpoint API - #23456
Conversation
agparadiso
changed the title
|
✅ No conflicts with other open PRs targeting |
|
I see you updated files related to
|
… admission control
a515440 to
dd45db2
Compare
| // Legacy path ignores the error on purpose. startExecution already handles all errors internally. not handling here to avoid duplication. | ||
| // future dispatcher admitter (CRE-6176) will use this error. |
There was a problem hiding this comment.
add a LifecycleHook that can be implemented to handle the error
| } | ||
| } | ||
|
|
||
| func (e *Engine) HandleTriggerEvent(ctx context.Context, event routedTriggerEvent) error { |
There was a problem hiding this comment.
define interface for TriggerExecutor, I think maybe Execute or ExecuteTrigger is better for the method name, thoughts?
| event capabilities.TriggerResponse | ||
| } | ||
|
|
||
| type routedTriggerEvent struct { |
There was a problem hiding this comment.
remove the enqueuedTriggerEvent type as well
There was a problem hiding this comment.
this is still used by allTriggerEventsQueueCh I'll remove it on CRE-6175
d4c68e9 to
690bf1e
Compare
|
2 participants
Requires
Supports