Skip to content

Use SpendValueInGasUnits in metering - #23453

Open
russell-stern wants to merge 7 commits into
developfrom
non_evm_metering
Open

Use SpendValueInGasUnits in metering#23453
russell-stern wants to merge 7 commits into
developfrom
non_evm_metering

Conversation

@russell-stern

@russell-stern russell-stern commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@russell-stern
russell-stern requested review from a team as code owners August 19, 2026 13:10
@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

👋 russell-stern, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io

trunk-io Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

dhaidashenko
dhaidashenko reviewed Aug 19, 2026
View reviewed changes
Comment thread core/services/workflows/metering/metering.go Outdated
var value decimal.Decimal
var err error

if isGasSpendType(unit) && detail.SpendValueInGasUnits != "" {

@dhaidashenko dhaidashenko Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should be a separate method.
The settle function is too long

patrickhuie19
patrickhuie19 previously approved these changes Aug 20, 2026
View reviewed changes
@russell-stern
russell-stern requested a review from a team as a code owner August 21, 2026 18:28
@cl-sonarqube-production

cl-sonarqube-production Bot commented Aug 21, 2026

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
2 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhaidashenko dhaidashenko dhaidashenko left review comments
@patrickhuie19 patrickhuie19 patrickhuie19 left review comments
@skudasov skudasov Awaiting requested review from skudasov
@mchain0 mchain0 Awaiting requested review from mchain0
@kalverra kalverra Awaiting requested review from kalverra

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@russell-stern @patrickhuie19 @dhaidashenko