Skip to content

[DX-4492] Speed up functions Tests#22957

Draft
kalverra wants to merge 16 commits into
developfrom
speedUpFunctions
Draft

[DX-4492] Speed up functions Tests#22957
kalverra wants to merge 16 commits into
developfrom
speedUpFunctions

Conversation

@kalverra

Copy link
Copy Markdown
Collaborator

Speeds up core/services/ocr2/plugins/functions/integration_tests/v1 tests, the 6th slowest test package in core/.

Results

Before After Absolute Delta % Delta
46s 18s 28s 60%

How

  1. t.Parallel()
  2. Faster polling

Confirmed tests pass and aren't flaky after changes with 25 iterations.

❯ make test ARGS="diagnose --iterations 25 -- ./core/..."

Also includes various linting fixes and t.Parallel() calls.

@github-actions

Copy link
Copy Markdown
Contributor

👋 kalverra, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

CORA - Pending Reviewers

Codeowners Entry Overall Num Files Owners
/core/capabilities/ 23 @smartcontractkit/keystone, @smartcontractkit/capabilities-team
/core/services/ocr*/ 1 @smartcontractkit/foundations, @smartcontractkit/core
/core/services/ocr2/plugins/ocr2keeper/ 14 @smartcontractkit/dev-services
/core/services/ocr2/plugins/functions/ 10 @smartcontractkit/dev-services
/core/services/workflows/ 1 @smartcontractkit/keystone
/tools/test/ 2 @smartcontractkit/devex-cicd, @smartcontractkit/devex-tooling, @smartcontractkit/core

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@github-actions

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@trunk-io

trunk-io Bot commented Jun 24, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
TestShell_BeholderLifecycle/after_node_is_idempotent The test failed because the database could not accept new connections due to all connection slots being reserved for superusers. Logs ↗︎
TestMaliciousConsumer The test failed during initialization due to an error in setting up the test environment or dependencies. Logs ↗︎
TestShell_BeholderLifecycle/log_streaming_sets_otel_core The test failed because the database could not accept new connections due to all connection slots being reserved for superusers. Logs ↗︎
TestShell_BeholderLifecycle The test 'TestShell_BeholderLifecycle' failed during execution. Logs ↗︎

View Full Report ↗︎Docs

@kalverra kalverra requested review from a team as code owners June 24, 2026 20:57
@cl-sonarqube-production

Copy link
Copy Markdown

@kalverra kalverra marked this pull request as draft June 25, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants