[DX-4492] Speed up keystone Tests#22943
Open
kalverra wants to merge 7 commits into
Open
Conversation
product-security-plaid-production
Bot
requested review from
bolekk,
ecPablo,
erikburt and
prashantkumar1982
Contributor
CORA - Pending Reviewers
Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
|
silaslenihan
approved these changes
Jun 24, 2026
|
|
||
| <lessons-learned> | ||
| 1. Block mining bottleneck. Lower `cltest.Mine` frequency. Simulation resolve faster. Mine faster than `DeltaRound` or hit "cannot access old blocks" error. | ||
| 2. EVM polling slow. Lower `LogPollInterval` to 100ms. Nodes find events faster. |
Contributor
There was a problem hiding this comment.
Suggested change
| 2. EVM polling slow. Lower `LogPollInterval` to 100ms. Nodes find events faster. | |
| 2. EVM polling slow. Lower `LogPollInterval` to 500ms. Nodes find events faster. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speeds up
core/capabilities/integration_tests/keystonetests, the 5th slowest test package incore/.Results
How
Confirmed tests pass and aren't flaky after changes with
25iterations.Also includes various linting fixes and
t.Parallel()calls.