Skip to content

[DX-4492] Speed Up ocr2keeper Tests#22942

Open
kalverra wants to merge 5 commits into
developfrom
speedUpTests
Open

[DX-4492] Speed Up ocr2keeper Tests#22942
kalverra wants to merge 5 commits into
developfrom
speedUpTests

Conversation

@kalverra

@kalverra kalverra commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Speeds up core/services/ocr2/plugins/ocr2keeper tests, the 4th slowest test package in core/.

Results

Before After Absolute Delta % Delta
1m0s 49s 11s 18.33%

How

  1. Mine blocks faster with cltest.Mine at 200ms
  2. LogPollInterval faster at 100ms
  3. DeltaDial and DeltaReconcile faster at 100ms

Confirmed tests pass and aren't flaky after changes with 25 iterations.

❯ make test ARGS="diagnose --iterations 25 -- ./core/..."

Also includes various linting fixes and t.Parallel() calls.

@github-actions

Copy link
Copy Markdown
Contributor

👋 kalverra, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@kalverra kalverra changed the title [DX-4449] Speed Up ocr2keeper Tests [DX-4492] Speed Up ocr2keeper Tests Jun 24, 2026
@trunk-io

trunk-io Bot commented Jun 24, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

sebawo
sebawo previously approved these changes Jun 25, 2026
@sebawo

sebawo commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@kalverra please check failing CI checks.

@cl-sonarqube-production

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants