Skip to content

fix(vault): downgrade duplicate-response log from error to info#22275

Open
prashantkumar1982 wants to merge 1 commit intodevelopfrom
vault/fix-response-log-level
Open

fix(vault): downgrade duplicate-response log from error to info#22275
prashantkumar1982 wants to merge 1 commit intodevelopfrom
vault/fix-response-log-level

Conversation

@prashantkumar1982
Copy link
Copy Markdown
Contributor

Summary

  • Downgraded log level from error to info for the duplicate-response case in vault handler
  • Renamed log message from "error sending response to user" to "failed to send response to user"
  • This fires when a second node reaches quorum concurrently and tries to send an already-sent response — expected race, not a true error

  The "failed to send response to user" case occurs when a second node
  reaches quorum and attempts to send a response that was already sent
  by a concurrent goroutine. This is an expected race condition, not an
  error — the user already received their response successfully.
@github-actions
Copy link
Copy Markdown
Contributor

👋 prashantkumar1982, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Apr 30, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Test_CRE_V2_Aptos_Suite/[v2]_Aptos The test failed without a specific error message, likely due to an unspecified issue during the test execution. Logs ↗︎
Test_CRE_V2_Aptos_Suite The test failed without a specific error message, likely due to an issue during execution or setup. Logs ↗︎
Test_CRE_V2_Aptos_Suite/[v2]_Aptos The test failed without a specific error message, indicating an unspecified failure during the test execution. Logs ↗︎
Test_CRE_V2_Aptos_Suite/[v2]_Aptos The test failed without providing specific error details, indicating an unspecified failure in the test suite. Logs ↗︎

... and 11 more

View Full Report ↗︎Docs

@cl-sonarqube-production
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants