Skip to content

Remove solana crcw config as ContractTransimitter #22274

Merged
huangzhen1997 merged 3 commits intodevelopfrom
jh/rm-solana-crcw-config
May 1, 2026
Merged

Remove solana crcw config as ContractTransimitter #22274
huangzhen1997 merged 3 commits intodevelopfrom
jh/rm-solana-crcw-config

Conversation

@huangzhen1997
Copy link
Copy Markdown
Contributor

@huangzhen1997 huangzhen1997 commented Apr 30, 2026

Jira

Chain reader and chain writer config is no longer needed, as Solana uses CCIP provider to create contractTransmitter

@github-actions
Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

✅ No conflicts with other open PRs targeting develop

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Apr 30, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: MEDIUM

This PR removes Solana-specific chain reader/writer (CRCW) configuration plumbing in favor of using the Solana CCIPProvider to supply the required chain accessor and contract transmitter.

Changes:

  • Deleted Solana contract reader config generator and its associated JSON round-trip test.
  • Deleted Solana ChainRWProvider (CRCW) implementation used to create loop contract readers/writers from generated configs.
  • Updated Solana plugin config to no longer register a ChainRW provider (leaving it nil) while keeping CCIPProviderSupported: true.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
core/capabilities/ccip/configs/solana/contract_reader.go Removed Solana ContractReader config generation (IDL/config-based reader setup).
core/capabilities/ccip/configs/solana/contract_reader_test.go Removed test covering JSON marshal/unmarshal stability for the removed reader config.
core/capabilities/ccip/ccipsolana/crcwconfig.go Removed Solana CRCW provider that built ContractReader/ContractWriter via relayer config blobs.
core/capabilities/ccip/ccipsolana/pluginconfig.go Stops providing ChainRW for Solana plugin config while indicating CCIPProvider support.

Areas requiring scrupulous human review:

  • Validate that the Solana relayer’s NewCCIPProvider implementation reliably provides a non-nil ChainAccessor() and (critically) a non-nil ContractTransmitter() for Solana, since the in-process CRCW fallback path is removed here.
  • Confirm that any Solana runtime paths still requiring Loop ContractReader/ContractWriter (e.g., fee estimation or any non-provider read/write paths) are fully covered by the CCIPProvider path after this change.

@huangzhen1997 huangzhen1997 enabled auto-merge May 1, 2026 01:36
@huangzhen1997 huangzhen1997 added this pull request to the merge queue May 1, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 1, 2026
@huangzhen1997 huangzhen1997 added this pull request to the merge queue May 1, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 1, 2026
@huangzhen1997 huangzhen1997 added this pull request to the merge queue May 1, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 1, 2026
@huangzhen1997 huangzhen1997 added this pull request to the merge queue May 1, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 1, 2026
@huangzhen1997 huangzhen1997 added this pull request to the merge queue May 1, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 1, 2026
@huangzhen1997 huangzhen1997 enabled auto-merge May 1, 2026 14:27
@huangzhen1997 huangzhen1997 added this pull request to the merge queue May 1, 2026
@cl-sonarqube-production
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Merged via the queue into develop with commit 4e59fb5 May 1, 2026
272 of 275 checks passed
@huangzhen1997 huangzhen1997 deleted the jh/rm-solana-crcw-config branch May 1, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants