Remove solana crcw config as ContractTransimitter #22274
Merged
huangzhen1997 merged 3 commits intodevelopfrom May 1, 2026
Merged
Remove solana crcw config as ContractTransimitter #22274huangzhen1997 merged 3 commits intodevelopfrom
huangzhen1997 merged 3 commits intodevelopfrom
Conversation
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM
This PR removes Solana-specific chain reader/writer (CRCW) configuration plumbing in favor of using the Solana CCIPProvider to supply the required chain accessor and contract transmitter.
Changes:
- Deleted Solana contract reader config generator and its associated JSON round-trip test.
- Deleted Solana
ChainRWProvider(CRCW) implementation used to create loop contract readers/writers from generated configs. - Updated Solana plugin config to no longer register a
ChainRWprovider (leaving itnil) while keepingCCIPProviderSupported: true.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/capabilities/ccip/configs/solana/contract_reader.go | Removed Solana ContractReader config generation (IDL/config-based reader setup). |
| core/capabilities/ccip/configs/solana/contract_reader_test.go | Removed test covering JSON marshal/unmarshal stability for the removed reader config. |
| core/capabilities/ccip/ccipsolana/crcwconfig.go | Removed Solana CRCW provider that built ContractReader/ContractWriter via relayer config blobs. |
| core/capabilities/ccip/ccipsolana/pluginconfig.go | Stops providing ChainRW for Solana plugin config while indicating CCIPProvider support. |
Areas requiring scrupulous human review:
- Validate that the Solana relayer’s
NewCCIPProviderimplementation reliably provides a non-nilChainAccessor()and (critically) a non-nilContractTransmitter()for Solana, since the in-process CRCW fallback path is removed here. - Confirm that any Solana runtime paths still requiring Loop ContractReader/ContractWriter (e.g., fee estimation or any non-provider read/write paths) are fully covered by the CCIPProvider path after this change.
jmank88
approved these changes
Apr 30, 2026
ogtownsend
approved these changes
May 1, 2026
…jh/rm-solana-crcw-config
…jh/rm-solana-crcw-config
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Jira
Chain reader and chain writer config is no longer needed, as Solana uses CCIP provider to create contractTransmitter