Vault ocr3 changes#22270
Conversation
product-security-plaid-production
Bot
requested review from
fernandofederico1984 and
gustavogama-cll
|
👋 cedric-cordenier, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
✅ No conflicts with other open PRs targeting |
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM — introduces new OCR3.1/DKG config generation paths and a version switch in capabilities-registry config expansion.
This PR extends CRE deployment tooling to support OCR3.1 (including DKG and Vault plugin offchain configs) and allows capabilities-registry OCR config expansion to select the OCR version per entry.
Changes:
- Add OCR3.1 registry helpers (
ComputeOCR3_1Config,ComputeDKGConfig) and support deriving OCR3.1 offchain config bytes from structured config (DKG/Vault) when no override is provided. - Refactor DKG OCR3.1 config generation to reuse the shared OCR3.1 config builder and centralize identity derivation.
- Update capabilities-registry OCR config expansion to support
__ocrVersion__selection (ocr3,ocr3_1,ocr3_1_DKG) and adjust test expectation text.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| deployment/cre/ocr3/ocr3_1/registry.go | New entrypoints to compute OCR3.1 and DKG configs using JD-fetched node info. |
| deployment/cre/ocr3/ocr3_1/oracle_config.go | New structured offchain config types (DKG/Vault) with marshaling support. |
| deployment/cre/ocr3/ocr3_1/config_dkg.go | Refactors DKG config generation to reuse shared OCR3.1 builder and adds identity derivation helper. |
| deployment/cre/ocr3/ocr3_1/config.go | Adds fallback logic to marshal offchain config from V3_1OracleConfig when no override is provided. |
| deployment/cre/capabilities_registry/v2/changeset/configure_capabilities_registry.go | Adds OCR version switching and parsing for OCR3.1/DKG configs during expansion. |
| deployment/cre/capabilities_registry/v2/changeset/expand_ocr3_configs_test.go | Updates an assertion string to match new error wording. |
|
|
||
| pkBytesFixed := [ed25519.PublicKeySize]byte{} | ||
| nCopied := copy(pkBytesFixed[:], pkBytes) | ||
| if nCopied != ed25519.PublicKeySize { | ||
| return nil, nil, fmt.Errorf("wrong num elements copied from ocr2 offchain public key. expected %d but got %d", ed25519.PublicKeySize, nCopied) | ||
| } |
cedric-cordenier
force-pushed
the
vault-ocr3-changes
branch
2 times, most recently
from
da218a9 to
9cff59c
Compare
- Including support for Vault and DKG
cedric-cordenier
force-pushed
the
vault-ocr3-changes
branch
from
9cff59c to
1196bf4
Compare
|
Requires
Supports