PLEX-2557: adjusting log levels depending on the type of capability error#22268
Open
fernandezlautaro wants to merge 1 commit intodevelopfrom
Open
PLEX-2557: adjusting log levels depending on the type of capability error#22268fernandezlautaro wants to merge 1 commit intodevelopfrom
fernandezlautaro wants to merge 1 commit intodevelopfrom
Conversation
product-security-plaid-production
Bot
requested review from
archseer and
cedric-cordenier
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: LOW
Adjusts logging verbosity so capability user errors are less noisy while system/unknown errors are more visible, improving operational signal for workflow/capability failures.
Changes:
- Promote capability execution failures that are system/unknown-origin from
DebugwtoErrorwin the workflow capability executor. - Demote trigger registration failures that are user-origin (non-retriable) from
ErrorwtoDebugwin the remote trigger publisher.
Scrupulous human review suggested (small but operationally relevant):
core/services/workflows/v2/capability_executor.goaround the capability error classification/logging path (log volume/alerting impact).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| core/services/workflows/v2/capability_executor.go | Raises log level for system/unknown capability execution failures to improve visibility. |
| core/capabilities/remote/trigger_publisher.go | Lowers log level for user-origin registration failures to reduce noise while preserving retry behavior for system errors. |
silaslenihan
approved these changes
Apr 30, 2026
|
|
dhaidashenko
approved these changes
Apr 30, 2026
fernandezlautaro
force-pushed
the
PLEX-2557
branch
from
52f45b0 to
d3a6881
Compare
|
ilija42
approved these changes
May 4, 2026
DylanTinianov
approved these changes
May 4, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
DylanTinianov
approved these changes
May 4, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://smartcontract-it.atlassian.net/browse/PLEX-2557
Requires
Supports