[CRE] fix flaky TestComputeFetch and TestIntegration_LLO_tombstone tests#22207
Draft
[CRE] fix flaky TestComputeFetch and TestIntegration_LLO_tombstone tests#22207
Conversation
TestComputeFetch / TestComputeFetchMaxResponseSizeBytes: replace require.NoError with assert.NoError in mock Run callbacks that execute inside worker goroutines. require.FailNow terminates the goroutine via runtime.Goexit, starving the response channel and causing spurious context-canceled hangs. Fixes CRE-3923. TestIntegration_LLO_tombstone_stops_observations_and_reports: remove t.Parallel() to prevent OOM kills on CI (5 full nodes + DBs per test, concurrent execution exhausts memory before the first assertion). Also increase post-tombstone sleep 1s→3s to give in-flight pipeline executions time to complete before the bridge-call count is snapshotted. Fixes CRE-3921. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
✅ No conflicts with other open PRs targeting |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestComputeFetch / TestComputeFetchMaxResponseSizeBytes: replace require.NoError with assert.NoError in mock Run callbacks that execute inside worker goroutines. require.FailNow terminates the goroutine via runtime.Goexit, starving the response channel and causing spurious context-canceled hangs. Fixes CRE-3923.
TestIntegration_LLO_tombstone_stops_observations_and_reports: remove t.Parallel() to prevent OOM kills on CI (5 full nodes + DBs per test, concurrent execution exhausts memory before the first assertion). Also increase post-tombstone sleep 1s→3s to give in-flight pipeline executions time to complete before the bridge-call count is snapshotted. Fixes CRE-3921.