Emit node job info platform events by gheorghestrimtu · Pull Request #22175 · smartcontractkit/chainlink

gheorghestrimtu · 2026-04-24T17:20:57Z

Summary

Updates the node-platform job info emitter to use the new NodeJobInfo.submitter_addresses proto shape from the merged chainlink-protos/node-platform commit acccf17ece83099c7e4d91bd3e40b2d65b47b356.

The emitted entries preserve the Chainlink job source field names through field_path, including:

transmitterAddress
transmitterID
relayConfig.sendingKeys
relayConfig.dualTransmission.transmitterAddress
fromAddresses
oracle_factory.transmitter_id
observationSource.ethtx.from

The implementation emits one source-aware submitter address entry per chain/job/plugin/field path, with deduped sorted addresses.

Notes

OCR2 Mercury and LLO transmitterID values are excluded because those are offchain transmitter identities, not gas-paying on-chain submitter addresses.
Static job fields are covered for OCR, OCR2, VRF, BlockhashStore, BlockHeaderFeeder, LegacyGasStationServer, Standard Capabilities, and explicit static ethtx.from pipeline values.
Legacy Keeper job support was removed on latest develop, so the old Keeper fromAddress path is no longer emitted.
The chainlink-protos/node-platform dependency was updated across root and nested Go modules via make gomodtidy.

Validation

make gomodtidy
GOTOOLCHAIN=auto GOCACHE=/tmp/go-build go test -count=1 ./core/services/chainlink -run 'NodePlatform(BuildInfo|JobInfo)'
GOTOOLCHAIN=auto GOCACHE=/tmp/go-build go test -count=1 ./core/services/chainlink -run '^$'
cd system-tests/tests && GOTOOLCHAIN=auto GOCACHE=/tmp/go-build go test -run '^$' ./...
git diff --check

github-actions · 2026-04-24T17:22:06Z

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

#added For any new functionality added.
#breaking_change For any functionality that requires manual action for the node to boot.
#bugfix For bug fixes.
#changed For any change to the existing functionality.
#db_update For any feature that introduces updates to database schema.
#deprecation_notice For any upcoming deprecation functionality.
#internal For changesets that need to be excluded from the final changelog.
#nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
#removed For any functionality/config that is removed.
#updated For any functionality that is updated.
#wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

github-actions · 2026-04-24T17:22:21Z

✅ No conflicts with other open PRs targeting develop

trunk-io · 2026-04-24T17:40:10Z

_{View Full Report ↗︎ ⋅ Docs}

…aitForReportWithTimestamp

Copilot

Pull request overview

Risk Rating: MEDIUM — introduces a new always-on background service that periodically queries the jobs table and emits telemetry events.

Updates node-platform telemetry emission to support the new NodeJobInfo.submitter_addresses proto shape and exposes a new NodePlatformJobInfo health check alongside existing node-platform build info emission.

Changes:

Add NodePlatformJobInfoService to emit common.v1.NodeJobInfo platform events with source-aware submitter address entries derived from job specs and pipeline ETHTx tasks.
Wire the new service into NewApplication and update health endpoint golden test fixtures to include NodePlatformJobInfo.
Bump chainlink-protos/node-platform dependency (root + nested Go modules) to the commit that contains the new proto shape.

Areas requiring scrupulous human review:

core/services/chainlink/node_platform.go: the job enumeration strategy inside submitterAddresses() (DB load / runtime impact) and the address extraction logic from job/pipeline fields.

Reviewed changes

Copilot reviewed 16 out of 23 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
testdata/scripts/health/multi-chain.txtar	Updates golden health output to include `NodePlatformJobInfo`.
testdata/scripts/health/multi-chain-loopp.txtar	Updates golden health output to include `NodePlatformJobInfo`.
testdata/scripts/health/default.txtar	Updates golden health output to include `NodePlatformJobInfo`.
core/web/testdata/body/health.txt	Updates plain-text health fixture with `NodePlatformJobInfo`.
core/web/testdata/body/health.json	Updates JSON health fixture with `NodePlatformJobInfo` check block.
core/web/testdata/body/health.html	Updates HTML health fixture with `NodePlatformJobInfo` section.
core/services/chainlink/node_platform.go	Implements `NodePlatformJobInfoService` + submitter-address extraction helpers; renames build-info entity const.
core/services/chainlink/node_platform_test.go	Adds unit test covering submitter address extraction/emission behavior.
core/services/chainlink/application.go	Wires `NodePlatformJobInfoService` into application service list.
go.mod	Bumps `chainlink-protos/node-platform` version.
go.sum	Updates checksums for new `chainlink-protos/node-platform` version.
deployment/go.mod	Bumps `chainlink-protos/node-platform` (indirect).
deployment/go.sum	Updates checksums for dependency bump.
core/scripts/go.mod	Bumps `chainlink-protos/node-platform` (indirect).
core/scripts/go.sum	Updates checksums for dependency bump.
integration-tests/go.mod	Bumps `chainlink-protos/node-platform` (indirect).
integration-tests/go.sum	Updates checksums for dependency bump.
integration-tests/load/go.mod	Bumps `chainlink-protos/node-platform` (indirect).
integration-tests/load/go.sum	Updates checksums for dependency bump.
system-tests/lib/go.mod	Bumps `chainlink-protos/node-platform` (indirect).
system-tests/lib/go.sum	Updates checksums for dependency bump.
system-tests/tests/go.mod	Bumps `chainlink-protos/node-platform` (indirect).
system-tests/tests/go.sum	Updates checksums for dependency bump.

Copilot · 2026-04-30T19:26:59Z

+func (s *NodePlatformJobInfoService) submitterAddresses(ctx context.Context) []*commonv1.NodeSubmitterAddress {
+	if s.opts.JobReader == nil {
+		return nil
+	}
+
+	jobs, _, err := s.opts.JobReader.FindJobs(ctx, 0, math.MaxInt)
+	if err != nil {
+		s.eng.Warnw("failed to resolve node-platform submitter addresses", "err", err)
+		return nil
+	}
+
+	return nodeSubmitterAddressesFromJobs(jobs)
+}


submitterAddresses calls FindJobs(ctx, 0, math.MaxInt), which loads all jobs (and FindJobs also loads job type details) every beat. On nodes with many jobs this can cause large DB queries, high memory usage, and long emit latencies. Consider paging through jobs with a reasonable limit (e.g., 500/1000) using the returned count, or adding a lighter-weight query on the JobReader that returns only the fields needed for submitter address extraction.

cl-sonarqube-production · 2026-04-30T20:14:35Z

Quality Gate passed

Issues
0 New issues
4 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

jmank88 · 2026-04-30T20:27:50Z

+	nodePlatformBuildInfoEntity = "common.v1.NodeBuildInfo"
+	nodePlatformJobInfoEntity   = "common.v1.NodeJobInfo"
+	nodePlatformDataSchema      = "/node-platform/common/v1"


What does common mean in this context?

jmank88 · 2026-04-30T20:32:24Z

Is there a an example of the raw structure being emitted? I'm having trouble reading all the nested helper funcs.

jmank88 · 2026-04-30T20:37:01Z

+	addNodeSubmitterAddress(bySource, spec.OracleFactory.ChainID, jobType(jb, job.StandardCapabilities), "", nodeSubmitterFieldOracleFactoryTransmitterID, spec.OracleFactory.TransmitterID)
+}
+
+func addPipelineETHTxSubmitterAddresses(bySource map[nodeSubmitterAddressKey]map[string]struct{}, jb job.Job) {


Can we find a way to have these funcs produce a result instead of modify an argument? If you are worried about efficiency, then iter.Seq2s can be used. Otherwise, a basic builder type with methods would help.

jmank88 · 2026-04-30T21:06:37Z

+		addresses := make([]string, 0, len(bySource[key]))
+		for address := range bySource[key] {
+			addresses = append(addresses, address)
+		}
+		sort.Strings(addresses)
+		if len(addresses) == 0 {
+			continue
+		}


Suggested change

addresses := make([]string, 0, len(bySource[key]))

for address := range bySource[key] {

addresses = append(addresses, address)

}

sort.Strings(addresses)

if len(addresses) == 0 {

continue

}

if len(bySource[key]) == 0 {

continue

}

addresses := slices.Sorted(maps.Keys(bySource[key])

Emit node job info platform events

d255c07

gheorghestrimtu added the build-publish Build and Publish image to SDLC label Apr 24, 2026

gheorghestrimtu added 3 commits April 27, 2026 18:03

test: update health fixtures for node job info service

7befc8b

feat(node-platform): emit job submitter addresses

9da5bd2

Merge origin/develop into RANE-4423-emit-node-transmitter-addresses

7cc621c

gheorghestrimtu force-pushed the RANE-4423-emit-node-transmitter-addresses branch from 6317f74 to 7cc621c Compare April 28, 2026 17:44

gheorghestrimtu added 3 commits April 30, 2026 20:33

chore: update node-platform protos dependency

96986d3

Merge origin/develop into RANE-4423-emit-node-transmitter-addresses

cfda0f5

fix: improve error message formatting for non-existent timestamp in w…

d680171

…aitForReportWithTimestamp

gheorghestrimtu marked this pull request as ready for review April 30, 2026 19:22

gheorghestrimtu requested a review from a team as a code owner April 30, 2026 19:22

Copilot AI review requested due to automatic review settings April 30, 2026 19:22

gheorghestrimtu requested review from a team as code owners April 30, 2026 19:22

product-security-plaid-production Bot requested review from DylanTinianov, gustavogama-cll and kalverra April 30, 2026 19:22

Copilot started reviewing on behalf of gheorghestrimtu April 30, 2026 19:23 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

gheorghestrimtu added 2 commits April 30, 2026 22:34

fix: page node job info submitter address queries

b2ff724

fix: remove unused node job info helper

6bedbba

jmank88 reviewed Apr 30, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Emit node job info platform events#22175

Emit node job info platform events#22175
gheorghestrimtu wants to merge 9 commits intodevelopfrom
RANE-4423-emit-node-transmitter-addresses

gheorghestrimtu commented Apr 24, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 24, 2026

Uh oh!

github-actions Bot commented Apr 24, 2026 •

edited

Loading

Uh oh!

trunk-io Bot commented Apr 24, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 30, 2026

Uh oh!

cl-sonarqube-production Bot commented Apr 30, 2026

Uh oh!

jmank88 Apr 30, 2026

Uh oh!

jmank88 Apr 30, 2026

Uh oh!

jmank88 Apr 30, 2026

Uh oh!

jmank88 Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

gheorghestrimtu commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Notes

Validation

Uh oh!

github-actions Bot commented Apr 24, 2026

Uh oh!

github-actions Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trunk-io Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

cl-sonarqube-production Bot commented Apr 30, 2026

Quality Gate passed

Uh oh!

jmank88 Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

jmank88 Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

jmank88 Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

jmank88 Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gheorghestrimtu commented Apr 24, 2026 •

edited

Loading

github-actions Bot commented Apr 24, 2026 •

edited

Loading

trunk-io Bot commented Apr 24, 2026 •

edited

Loading