DurableEmitter: Instrument Callsites#2134
Open
DylanTinianov wants to merge 2 commits into
Open
Conversation
📊 API Diff Results
|
DylanTinianov
changed the title
tarcisiozf
approved these changes
Jun 8, 2026
| d := globalEmitter.Load() | ||
| if d == nil { | ||
| return errors.New("global DurableEmitter not initialized; call durableemitter.Setup first") | ||
| return nil |
Contributor
There was a problem hiding this comment.
this coalesces a negative path with a happy path which is not ideal. IMHO a better path forward is to either keep the error path as is, or define explicit error types that a consumer can switch case on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add emit callsites and noop if not initialized to prevent plumbing config everywhere.